You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:46:38 UTC

[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2908: [Feature][Core][Connector-V2] Unified The way of setting JobName

CalvinKirs commented on code in PR #2908:
URL: https://github.com/apache/incubator-seatunnel/pull/2908#discussion_r981020019


##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java:
##########
@@ -41,6 +42,10 @@ public abstract class AbstractCommandArgs implements CommandArgs {
             description = "check config")
     private boolean checkConfig = false;
 
+    @Parameter(names = {"-n", "--name"},

Review Comment:
   in fact, `connectot-v2` it's not much different from v1, it's just the scripts and jars that are started. Are you willing to submit documents in this regard?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org