[GitHub] [hadoop] steveloughran commented on issue #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a

[GitBox <gi...@apache.org>]

steveloughran commented on issue #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a
URL: https://github.com/apache/hadoop/pull/1516#issuecomment-537653096
 
 
   patch LGTM, +1 once you fix whatever merge conflicts have crept in (Constants, inevitably)
   
   regarding instrumentation, it'd make sense to have some interface for the signers to invoke with some signed/rejected counters; we'd have an implementation in S3AInstrumentation which would be the one normally passed down.
   Now, if we also wanted to track signing latency, that would be fun -and it might something we'd always want to track, given the various extension points for auth which exist (AWS IAM stuff, our DT plugins, etc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org