[GitHub] [superset] a-cid edited a comment on issue #15962: [1.2 regression] Simple Filter generating invalid SQL when filtering on DOUBLE columns

[GitBox <gi...@apache.org>]

a-cid edited a comment on issue #15962:
URL: https://github.com/apache/superset/issues/15962#issuecomment-894395865


   I've managed to fix the problem by editing superset/db_engine_specs/base.py
   
   In the PyPI version,  `column_type_mappings` is missing [entries for float and double which are already in master](https://github.com/apache/superset/blob/772da8de6353f01ea1c64037af9695d5f10b71e4/superset/db_engine_specs/base.py#L202).
   
   This fixes the issue with double type column filters. The issue with boolean filters seems to have a different cause, which I believe is addressed by PR #16107.
   
   Would be nice to see small fixes for issues like this published to PyPI. But I understand it isn't the recommended deployment method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org