You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/18 12:39:09 UTC

[GitHub] [flink] kl0u opened a new pull request #8209: [FLINK-11889] Remove "stop" signal and related interfaces.

kl0u opened a new pull request #8209: [FLINK-11889] Remove "stop" signal and related interfaces.
URL: https://github.com/apache/flink/pull/8209
 
 
   ## What is the purpose of the change
   
   This change aims at removing the "old" STOP command, as decided in the related discussion in the mailing list (please see related JIRA for a link to the discussion). In addition, after the merging of the commits related to FLIP-34 and https://issues.apache.org/jira/browse/FLINK-11458, the semantics of the STOP command have now change.
   
   ## Brief change log
   
   - *The old "stop" REST API call returns a meaningful error code  *
   - *The `StoppableStreamSource`, `StoppableStreamSourceTask`, `StoppableInvokable` and `StoppableFunction` have been removed *
   - *All the code paths that make use of the above (RPCs on TaskManager and JobManager, etc) have been removed*
   
   ## Verifying this change
   
   This change removes functionality and is "verified" by the fact that no test fails.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no although it changes a REST API call**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   
   R @zentol 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services