[jira] [Commented] (LANG-1197) Prepare Java 9 detection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482300#comment-15482300 ] 

ASF GitHub Bot commented on LANG-1197:
--------------------------------------

Github user britter commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/163#discussion_r78301302
  
    --- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
    @@ -72,8 +72,15 @@
     
         /**
          * Java 1.9.
    +     * 
    +     * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
    +     */
    +    JAVA_1_9(1.9f, "9"),
    +
    +    /**
    +     * Java 9
          */
    -    JAVA_1_9(1.9f, "1.9"),
    +    JAVA_9(1.9f, "9"),
    --- End diff --
    
    I agree with Michael


> Prepare Java 9 detection
> ------------------------
>
>                 Key: LANG-1197
>                 URL: https://issues.apache.org/jira/browse/LANG-1197
>             Project: Commons Lang
>          Issue Type: Task
>          Components: lang.*
>    Affects Versions: 3.4
>            Reporter: Michael Osipov
>
> In anticipation of Java 9 and [JEP 223|http://openjdk.java.net/jeps/223], the versioning scheme will change completely. We need to reflect that in {{SystemUtils}}, {{JavaVersion}}, etc.:
> * {{SystemUtils}}: Deprecate {{IS_JAVA_1_9}} and replace with {{IS_JAVA_9}}
> * {{JavaVersion}}: Deprecate {{JAVA_1_9}} in {{JavaVersion}} and replace with {{JAVA_9}}
> and other places in the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)