You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/16 10:54:10 UTC

[GitHub] [arrow] ucasfl commented on a diff in pull request #33684: [C++] Pass std::string_view by value

ucasfl commented on code in PR #33684:
URL: https://github.com/apache/arrow/pull/33684#discussion_r1071099834


##########
cpp/CMakeLists.txt:
##########
@@ -49,6 +49,8 @@ endif()
 
 set(ARROW_VERSION "11.0.0-SNAPSHOT")
 
+set(CMAKE_EXPORT_COMPILE_COMMANDS 1) # Write compile_commands.json

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org