[jira] Updated: (DERBY-1112) TemporaryRowHolderResultSet is breaking the contract of getActivation

["Knut Anders Hatlen (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-1112?page=all ]

Knut Anders Hatlen updated DERBY-1112:
--------------------------------------

    Attachment: derby-1112-v1.diff
                derby-1112-v1.stat

Uploading a patch that modifies the constructors of
TemporaryRowHolderImpl so that they take an Activation instead of a
TransactionController. The transaction controller can still be
obtained from the Activation object. TemporaryRowHolderResultSet now
implements getActivation() by returning the activation of the
TemporaryRowHolderImpl that created it.

The patch also makes TemporaryRowHolderImpl and
TemporaryRowHolderResultSet package protected.

Do these changes make sense? I'm not at all familiar with this code,
but they seem relatively safe to me.

No failures when running derbyall.

> TemporaryRowHolderResultSet is breaking the contract of getActivation
> ---------------------------------------------------------------------
>
>          Key: DERBY-1112
>          URL: http://issues.apache.org/jira/browse/DERBY-1112
>      Project: Derby
>         Type: Bug
>   Components: SQL
>     Versions: 10.2.0.0
>     Reporter: Knut Anders Hatlen
>     Priority: Minor
>  Attachments: derby-1112-v1.diff, derby-1112-v1.stat
>
> TemporaryRowHolderResultSet is breaking the contract of
> getActivation() by returning null in insane builds and raising an
> exception in sane builds. There is no comment saying why it does not
> honour its contract. This might be a bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira