You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/28 16:14:37 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #4456: Temporal Arithmetic Can Panic
tustvold opened a new issue, #4456:
URL: https://github.com/apache/arrow-rs/issues/4456
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
The temporal kernels make extensive use of chrono kernels, these in turn may panic
```
Date32Type::to_naive_date(i32::MAX);
TimestampNanosecondType::add_year_months(64, i32::MAX);
```
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
We should return an error on overflow
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Weijun-H commented on issue #4456: Temporal Arithmetic Can Panic
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #4456:
URL: https://github.com/apache/arrow-rs/issues/4456#issuecomment-1694931402
glad to pick this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Temporal Arithmetic Can Panic [arrow-rs]
Posted by "opensourcegeek (via GitHub)" <gi...@apache.org>.
opensourcegeek commented on issue #4456:
URL: https://github.com/apache/arrow-rs/issues/4456#issuecomment-2080457724
I'm new to this codebase, I can see the temporal aritmetic kernels / conversions have been updated and unwraps in place (keeping API compatibility I guess). Is the plan to introduce APIs that return some variant of Error back to caller? Happy to pick this up if anything is left to do on this one. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Temporal Arithmetic Can Panic [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #4456:
URL: https://github.com/apache/arrow-rs/issues/4456#issuecomment-1984570121
While updating to the latest chrono https://github.com/apache/arrow-rs/pull/5479/files @tustvold notes that chrono's APIs are getting less likely to panic, but to preserve API compatibility, now the code in arrow-rs panics explicitly. This seems like progress but we should eventually pass back the values to the caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Temporal Arithmetic Can Panic [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #4456:
URL: https://github.com/apache/arrow-rs/issues/4456#issuecomment-2080474524
There is no specific plan that I know of
I think introducing new fallable APIs (while keeping the existing non fallible ones) would be a nice improvement
I think the first thing to do would be to propose what the new API would look like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org