You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/02/17 23:36:24 UTC
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
-----------------------------------------------------------
(Updated Feb. 17, 2016, 10:36 p.m.)
Review request for mesos, Michael Park and Neil Conway.
Summary (updated)
-----------------
Updated comments and docs for '/(un)reserve' without principal.
Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940
Repository: mesos
Description
-------
Updated comments and docs for '/reserve' and '/unreserve' without principal.
Diffs
-----
docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646
include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54
Diff: https://reviews.apache.org/r/43642/diff/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120214
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
>
>
> Diffs
> -----
>
> docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
>
> Diff: https://reviews.apache.org/r/43642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120211
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
>
>
> Diffs
> -----
>
> docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
>
> Diff: https://reviews.apache.org/r/43642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120231
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
>
>
> Diffs
> -----
>
> docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
>
> Diff: https://reviews.apache.org/r/43642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120215
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43639, 43641, 43642]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 22, 2016, 6:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
>
>
> Diffs
> -----
>
> docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
>
> Diff: https://reviews.apache.org/r/43642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43642: Updated comments and docs for '/(un)reserve'
without principal.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 6:44 p.m.)
Review request for mesos, Michael Park and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940
Repository: mesos
Description
-------
Updated comments and docs for '/reserve' and '/unreserve' without principal.
Diffs (updated)
-----
docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
Diff: https://reviews.apache.org/r/43642/diff/
Testing
-------
Thanks,
Greg Mann