You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2026/09/12 12:04:34 UTC

[PR] Fix extra Dag versions from template field callables if paths change [airflow]

FrankYang0529 opened a new pull request, #73031:
URL: https://github.com/apache/airflow/pull/73031

   ## Why
   
   - `serialize_template_field()` writes a callable as `<callable {module}.{qualname}>` and a plain object as `<{module}.{qualname} object>`. For a function or class defined in the Dag file, the marker includes the path-based module name, which ends up in the Dag hash.
   - If the bundle path changes between deployments, the hash changes even though the Dag code stays the same. When the current version already has task instances, each of these deployments creates a new Dag version.
   
   ## How
   
   - Follow #60799 to pass `exclude_module=True` to `qualname()` for both markers.
   
   ## Verification
   
   - Unit test:
     - `uv run --frozen --project airflow-core pytest airflow-core/tests/unit/serialization/test_helpers.py airflow-core/tests/unit/serialization/test_dag_serialization.py airflow-core/tests/unit/models/test_renderedtifields.py`
     - `breeze run pytest task-sdk/tests/task_sdk/execution_time/test_task_runner.py`
   - Integration test:
   
   1. Setup
   
   ```sh
   mkdir -p files/template-field-demo
   
   cat > files/template-field-demo/etl.py <<'EOF'
   from __future__ import annotations
   
   import pendulum
   
   from airflow.providers.standard.operators.python import PythonOperator
   from airflow.sdk import DAG
   
   
   def clean_rows(rows):
       return [row.strip() for row in rows]
   
   
   class LoadSettings:
       batch_size = 500
   
   
   def load(transform, settings):
       print(transform([" a ", " b "]), settings.batch_size)
   
   
   with DAG(dag_id="etl", start_date=pendulum.datetime(2026, 1, 1, tz="UTC"), schedule=None):
       PythonOperator(
           task_id="load",
           python_callable=load,
           op_kwargs={"transform": clean_rows, "settings": LoadSettings()},
       )
   EOF
   
   cat > files/template-field-demo/show_state.py <<'EOF'
   import sys
   
   from sqlalchemy import select
   
   from airflow.models.dag_version import DagVersion
   from airflow.models.serialized_dag import SerializedDagModel
   from airflow.utils.session import create_session
   
   with create_session() as session:
       versions = session.scalars(
           select(DagVersion.version_number).where(DagVersion.dag_id == "etl").order_by(DagVersion.version_number)
       ).all()
       op_kwargs = SerializedDagModel.get("etl", session=session).data["dag"]["tasks"][0]["__var"]["op_kwargs"]
   
   print(f"{sys.argv[1]}: Dag versions = {versions}")
   print(f"  op_kwargs = {op_kwargs}")
   EOF
   
   cat > files/template-field-demo/deploy.sh <<'EOF'
   set -euo pipefail
   export AIRFLOW__CORE__LOAD_EXAMPLES=False
   # Write each re-serialization right away instead of waiting 30 seconds between writes.
   export AIRFLOW__CORE__MIN_SERIALIZED_DAG_UPDATE_INTERVAL=0
   demo=/files/template-field-demo
   
   quiet() { "$@" > /tmp/demo-command.log 2>&1 || { cat /tmp/demo-command.log; exit 1; }; }
   
   quiet airflow db migrate
   rm -rf "${demo}/releases"
   for release in 41 42 43; do
     # Deploy the same Dag file to a new directory, like a versioned deployment does.
     bundle_path="${demo}/releases/release-${release}"
     mkdir -p "${bundle_path}"
     cp "${demo}/etl.py" "${bundle_path}/etl.py"
     export AIRFLOW__DAG_PROCESSOR__DAG_BUNDLE_CONFIG_LIST="[{\"name\": \"etl-bundle\", \"classpath\": \"airflow.dag_processing.bundles.local.LocalDagBundle\", \"kwargs\": {\"path\": \"${bundle_path}\"}}]"
     quiet airflow dags reserialize --bundle-name etl-bundle
     python "${demo}/show_state.py" "release-${release}"
     # Run the Dag once, so the next deployment cannot update this version in place.
     quiet airflow dags trigger etl --run-id "manual__release-${release}"
   done
   EOF
   ```
   
   2. Run demo script
   
   ```sh
   breeze run --backend sqlite bash /files/template-field-demo/deploy.sh
   ```
   
   On main branch, it bumps dag version with different paths.
   
   ```text
   release-41: Dag versions = [1]
     op_kwargs = {'settings': '<unusual_prefix_b258b7f6578d0fef91ba779c52c32ad43a0d96b1_etl.LoadSettings object>', 'transform': '<callable unusual_prefix_b258b7f6578d0fef91ba779c52c32ad43a0d96b1_etl.clean_rows>'}
   release-42: Dag versions = [1, 2]
     op_kwargs = {'settings': '<unusual_prefix_30d5abbd19b0bdd47056ee70d929329f050eff4c_etl.LoadSettings object>', 'transform': '<callable unusual_prefix_30d5abbd19b0bdd47056ee70d929329f050eff4c_etl.clean_rows>'}
   release-43: Dag versions = [1, 2, 3]
     op_kwargs = {'settings': '<unusual_prefix_c6581b5a63a06e6a67c32562fc5425e66cef00de_etl.LoadSettings object>', 'transform': '<callable unusual_prefix_c6581b5a63a06e6a67c32562fc5425e66cef00de_etl.clean_rows>'}
   ```
   
   On this PR, it shows same version.
   
   ```text
   release-41: Dag versions = [1]
     op_kwargs = {'settings': '<LoadSettings object>', 'transform': '<callable clean_rows>'}
   release-42: Dag versions = [1]
     op_kwargs = {'settings': '<LoadSettings object>', 'transform': '<callable clean_rows>'}
   release-43: Dag versions = [1]
     op_kwargs = {'settings': '<LoadSettings object>', 'transform': '<callable clean_rows>'}
   ```
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [X] Yes - Claude Code
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix extra Dag versions from template field callables if paths change [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #73031: Fix extra Dag versions from template field callables if paths change
URL: https://github.com/apache/airflow/pull/73031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix extra Dag versions from template field callables if paths change [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #73031:
URL: https://github.com/apache/airflow/pull/73031#issuecomment-5839146683

   Hello @FrankYang0529 - thank you for your contributions to Apache Airflow!
   
   The Airflow community has introduced a limit of **5 open pull requests at a time** for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
   
   * #69698 - Avoid deactivating configured Dag bundles on transient get bundle errors
   * #71678 - Add gzip compression option for GCS remote task logs
   * #71775 - Fix comma-separated selected_fields in BigQuery to SQL transfers
   * #71837 - Fix the API server silently ignoring its gunicorn worker hooks
   * #72027 - Fix docs omitting asset from the Dag discovery safe-mode heuristic
   * #72104 - Add missing Druid Ingest connection type
   * #72138 - Fix scheduler crash when the Kafka event producer plugin is enabled
   * #72153 - Fix unscheduled tasks left on a stale Dag version
   * #72317 - Make AzureBatchOperator batch_max_retries take effect
   * #72593 - Fix airflow.utils.context deprecation shim returning a module object
   * #72626 - Support team-scoped secrets in LocalFilesystemBackend
   * #72802 - Honour dag_ignore_file_syntax in Task SDK and example plugin loading
   * #72858 - Restore CLI commands from custom executors and auth managers
   * #72884 - Restore helpful error for unregistered priority weight strategies
   * #72919 - Fix flaky test_trigger_log in triggerer job tests
   * #72920 - Fix API server failing to start when [api] access_logfile is set
   * #73020 - Fix missing task display name and map index in API audit logs
   * #73029 - Fail Gemini batch job operators when the job does not succeed
   * #73031 - Fix extra Dag versions from template field callables if paths change
   * #73032 - Fix Dags staying blocked by max_active_runs until the next parse
   * #73081 - Reject async callables in @task.virtualenv and @task.external_python
   * #73136 - Fix env var names in airflow config list for dotted and team sections
   * #73247 - Fix OpenLineage jobDependencies run ID after upstream task is cleared
   * #73312 - Fix SFTPSensor skipping python_callable in deferrable mode
   
   These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
   
   * #68625 - Add KafkaSharedStreamProducer and KafkaSharedStreamTrigger
   * #68778 - Add rerun policy for rollups when an upstream partition is re-run
   * #70351 - Replace AirflowException with ValueError in ProduceToTopicOperator
   * #71869 - Catch stale entries in the Java SDK dependency trust list
   * #72057 - Support priority_weight in EdgeExecutor
   * #73021 - Speed up the event logs API by loading only display names
   
   This is **not** a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.
   
   What we ask you to do is to make your **first prioritization decision**: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or `gh pr reopen <PR_NUMBER> --repo apache/airflow`. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.
   
   While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.
   
   Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.
   
   ---
   Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org