You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by pu...@apache.org on 2019/03/20 10:40:27 UTC
[royale-asjs] branch develop updated: Update DateField.as
This is an automated email from the ASF dual-hosted git repository.
pushminakazi pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 7cb6ee1 Update DateField.as
7cb6ee1 is described below
commit 7cb6ee1970eaf985fb35df0c3b1d64f309236fb5
Author: pashminakazi <42...@users.noreply.github.com>
AuthorDate: Wed Mar 20 15:40:22 2019 +0500
Update DateField.as
---
.../src/main/royale/mx/controls/DateField.as | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
index e12e414..ffa8837 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
@@ -1179,16 +1179,16 @@ public class DateField extends ComboBase
* @private
* Storage for the displayedYear property.
*/
- // private var _displayedYear:int = (new Date()).getFullYear();
+ private var _displayedYear:int = (new Date()).getFullYear();
/**
* @private
*/
- /* private var displayedYearChanged:Boolean = false;
+ private var displayedYearChanged:Boolean = false;
[Bindable("displayedYearChanged")]
[Inspectable(category="General")]
- */
+
/**
* Used with the <code>displayedMonth</code> property,
* the <code>displayedYear</code> property determines
@@ -1516,12 +1516,12 @@ public class DateField extends ComboBase
* @private
* Storage for the maxYear property.
*/
- //private var _maxYear:int = 2100;
+ private var _maxYear:int = 2100;
/**
* @private
*/
- // private var maxYearChanged:Boolean = false;
+ private var maxYearChanged:Boolean = false;
/**
* The last year selectable in the control.
@@ -1534,18 +1534,18 @@ public class DateField extends ComboBase
* @playerversion AIR 1.1
* @productversion Flex 3
*/
- /* public function get maxYear():int
+ public function get maxYear():int
{
if (dropdown)
return dropdown.maxYear;
else
return _maxYear;
- } */
+ }
/**
* @private
*/
- /* public function set maxYear(value:int):void
+ public function set maxYear(value:int):void
{
if (_maxYear == value)
return;
@@ -1554,7 +1554,7 @@ public class DateField extends ComboBase
maxYearChanged = true;
invalidateProperties();
- } */
+ }
//----------------------------------
// minYear
@@ -1582,18 +1582,18 @@ public class DateField extends ComboBase
* @playerversion AIR 1.1
* @productversion Flex 3
*/
- /* public function get minYear():int
+ public function get minYear():int
{
if (dropdown)
return dropdown.minYear;
else
return _minYear;
- } */
+ }
/**
* @private
*/
- /* public function set minYear(value:int):void
+ public function set minYear(value:int):void
{
if (_displayedYear == value)
return;
@@ -1602,7 +1602,7 @@ public class DateField extends ComboBase
minYearChanged = true;
invalidateProperties();
- } */
+ }
//----------------------------------
// monthNames
Re: [royale-asjs] branch develop updated: Update DateField.as
Posted by Carlos Rovira <ca...@apache.org>.
Hi Yishay,
didn't see your email
just commited a fix for this, but I should not be doing this
@pushmina.kazi@d-bz.com <pu...@d-bz.com> please, as I state some
hours ago. You should try as much as possible to commit reliable code. If
this code directly doesn't compile, it means you didn't try it.
We all can commit errors, but just want to warn you
thanks
El mié., 20 mar. 2019 a las 18:46, Yishay Weiss (<yi...@hotmail.com>)
escribió:
> This breaks the build with
>
>
>
> [java]
> C:\dev\flexjs\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\controls\DateField.as(1590):
> col: 20 Error: A
>
> ccess of possibly undefined property _minYear.
>
> [java]
>
> [java] return _minYear;
>
> [java] ^
>
> [java]
>
>
>
> ________________________________
> From: pushminakazi@apache.org <pu...@apache.org>
> Sent: Wednesday, March 20, 2019 12:40:27 PM
> To: commits@royale.apache.org
> Subject: [royale-asjs] branch develop updated: Update DateField.as
>
> This is an automated email from the ASF dual-hosted git repository.
>
> pushminakazi pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 7cb6ee1 Update DateField.as
> 7cb6ee1 is described below
>
> commit 7cb6ee1970eaf985fb35df0c3b1d64f309236fb5
> Author: pashminakazi <42...@users.noreply.github.com>
> AuthorDate: Wed Mar 20 15:40:22 2019 +0500
>
> Update DateField.as
> ---
> .../src/main/royale/mx/controls/DateField.as | 26
> +++++++++++-----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git
> a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
> b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
> index e12e414..ffa8837 100644
> --- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
> +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
> @@ -1179,16 +1179,16 @@ public class DateField extends ComboBase
> * @private
> * Storage for the displayedYear property.
> */
> - // private var _displayedYear:int = (new Date()).getFullYear();
> + private var _displayedYear:int = (new Date()).getFullYear();
>
> /**
> * @private
> */
> - /* private var displayedYearChanged:Boolean = false;
> + private var displayedYearChanged:Boolean = false;
>
> [Bindable("displayedYearChanged")]
> [Inspectable(category="General")]
> - */
> +
> /**
> * Used with the <code>displayedMonth</code> property,
> * the <code>displayedYear</code> property determines
> @@ -1516,12 +1516,12 @@ public class DateField extends ComboBase
> * @private
> * Storage for the maxYear property.
> */
> - //private var _maxYear:int = 2100;
> + private var _maxYear:int = 2100;
>
> /**
> * @private
> */
> - // private var maxYearChanged:Boolean = false;
> + private var maxYearChanged:Boolean = false;
>
> /**
> * The last year selectable in the control.
> @@ -1534,18 +1534,18 @@ public class DateField extends ComboBase
> * @playerversion AIR 1.1
> * @productversion Flex 3
> */
> - /* public function get maxYear():int
> + public function get maxYear():int
> {
> if (dropdown)
> return dropdown.maxYear;
> else
> return _maxYear;
> - } */
> + }
>
> /**
> * @private
> */
> - /* public function set maxYear(value:int):void
> + public function set maxYear(value:int):void
> {
> if (_maxYear == value)
> return;
> @@ -1554,7 +1554,7 @@ public class DateField extends ComboBase
> maxYearChanged = true;
>
> invalidateProperties();
> - } */
> + }
>
> //----------------------------------
> // minYear
> @@ -1582,18 +1582,18 @@ public class DateField extends ComboBase
> * @playerversion AIR 1.1
> * @productversion Flex 3
> */
> - /* public function get minYear():int
> + public function get minYear():int
> {
> if (dropdown)
> return dropdown.minYear;
> else
> return _minYear;
> - } */
> + }
>
> /**
> * @private
> */
> - /* public function set minYear(value:int):void
> + public function set minYear(value:int):void
> {
> if (_displayedYear == value)
> return;
> @@ -1602,7 +1602,7 @@ public class DateField extends ComboBase
> minYearChanged = true;
>
> invalidateProperties();
> - } */
> + }
>
> //----------------------------------
> // monthNames
>
>
--
Carlos Rovira
http://about.me/carlosrovira
RE: [royale-asjs] branch develop updated: Update DateField.as
Posted by Yishay Weiss <yi...@hotmail.com>.
This breaks the build with
[java] C:\dev\flexjs\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\controls\DateField.as(1590): col: 20 Error: A
ccess of possibly undefined property _minYear.
[java]
[java] return _minYear;
[java] ^
[java]
________________________________
From: pushminakazi@apache.org <pu...@apache.org>
Sent: Wednesday, March 20, 2019 12:40:27 PM
To: commits@royale.apache.org
Subject: [royale-asjs] branch develop updated: Update DateField.as
This is an automated email from the ASF dual-hosted git repository.
pushminakazi pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 7cb6ee1 Update DateField.as
7cb6ee1 is described below
commit 7cb6ee1970eaf985fb35df0c3b1d64f309236fb5
Author: pashminakazi <42...@users.noreply.github.com>
AuthorDate: Wed Mar 20 15:40:22 2019 +0500
Update DateField.as
---
.../src/main/royale/mx/controls/DateField.as | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
index e12e414..ffa8837 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/DateField.as
@@ -1179,16 +1179,16 @@ public class DateField extends ComboBase
* @private
* Storage for the displayedYear property.
*/
- // private var _displayedYear:int = (new Date()).getFullYear();
+ private var _displayedYear:int = (new Date()).getFullYear();
/**
* @private
*/
- /* private var displayedYearChanged:Boolean = false;
+ private var displayedYearChanged:Boolean = false;
[Bindable("displayedYearChanged")]
[Inspectable(category="General")]
- */
+
/**
* Used with the <code>displayedMonth</code> property,
* the <code>displayedYear</code> property determines
@@ -1516,12 +1516,12 @@ public class DateField extends ComboBase
* @private
* Storage for the maxYear property.
*/
- //private var _maxYear:int = 2100;
+ private var _maxYear:int = 2100;
/**
* @private
*/
- // private var maxYearChanged:Boolean = false;
+ private var maxYearChanged:Boolean = false;
/**
* The last year selectable in the control.
@@ -1534,18 +1534,18 @@ public class DateField extends ComboBase
* @playerversion AIR 1.1
* @productversion Flex 3
*/
- /* public function get maxYear():int
+ public function get maxYear():int
{
if (dropdown)
return dropdown.maxYear;
else
return _maxYear;
- } */
+ }
/**
* @private
*/
- /* public function set maxYear(value:int):void
+ public function set maxYear(value:int):void
{
if (_maxYear == value)
return;
@@ -1554,7 +1554,7 @@ public class DateField extends ComboBase
maxYearChanged = true;
invalidateProperties();
- } */
+ }
//----------------------------------
// minYear
@@ -1582,18 +1582,18 @@ public class DateField extends ComboBase
* @playerversion AIR 1.1
* @productversion Flex 3
*/
- /* public function get minYear():int
+ public function get minYear():int
{
if (dropdown)
return dropdown.minYear;
else
return _minYear;
- } */
+ }
/**
* @private
*/
- /* public function set minYear(value:int):void
+ public function set minYear(value:int):void
{
if (_displayedYear == value)
return;
@@ -1602,7 +1602,7 @@ public class DateField extends ComboBase
minYearChanged = true;
invalidateProperties();
- } */
+ }
//----------------------------------
// monthNames