You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/10 20:45:33 UTC
Review Request 58320: Added an upgrade test for executor
authentication.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
ensures that an executor which is launched with the
'--executor_secret_key' flag set but the
'--authenticate_http_executors' flag not set will be able to
subscribe successfully after the agent is restarted with the
'--authenticate_http_executors' flag set.
Diffs
-----
src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
Diff: https://reviews.apache.org/r/58320/diff/1/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/#review171659
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58321, 58320]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 11, 2017, 4:46 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58320/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:46 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
> ensures that an executor which is launched with the
> '--executor_secret_key' flag set but the
> '--authenticate_http_executors' flag not set will be able to
> subscribe successfully after the agent is restarted with the
> '--authenticate_http_executors' flag set.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
>
>
> Diff: https://reviews.apache.org/r/58320/diff/2/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 11, 2017, 7:18 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp
> > Lines 6041-6042 (patched)
> > <https://reviews.apache.org/r/58320/diff/2/?file=1687803#file1687803line6041>
> >
> > why is one a ref and not the other?
Whoops!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/#review171618
-----------------------------------------------------------
On April 12, 2017, 5:45 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58320/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 5:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
> ensures that an executor which is launched with the
> '--executor_secret_key' flag set but the
> '--authenticate_http_executors' flag not set will be able to
> subscribe successfully after the agent is restarted with the
> '--authenticate_http_executors' flag set.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
>
>
> Diff: https://reviews.apache.org/r/58320/diff/3/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/#review171618
-----------------------------------------------------------
Fix it, then Ship it!
Nice test!
src/tests/slave_tests.cpp
Lines 6041-6042 (patched)
<https://reviews.apache.org/r/58320/#comment244572>
why is one a ref and not the other?
- Vinod Kone
On April 11, 2017, 4:46 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58320/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:46 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
> ensures that an executor which is launched with the
> '--executor_secret_key' flag set but the
> '--authenticate_http_executors' flag not set will be able to
> subscribe successfully after the agent is restarted with the
> '--authenticate_http_executors' flag set.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
>
>
> Diff: https://reviews.apache.org/r/58320/diff/2/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/#review171795
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58321, 58320]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 12, 2017, 5:45 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58320/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 5:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
> ensures that an executor which is launched with the
> '--executor_secret_key' flag set but the
> '--authenticate_http_executors' flag not set will be able to
> subscribe successfully after the agent is restarted with the
> '--authenticate_http_executors' flag set.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
>
>
> Diff: https://reviews.apache.org/r/58320/diff/3/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/
-----------------------------------------------------------
(Updated April 12, 2017, 5:45 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
ensures that an executor which is launched with the
'--executor_secret_key' flag set but the
'--authenticate_http_executors' flag not set will be able to
subscribe successfully after the agent is restarted with the
'--authenticate_http_executors' flag set.
Diffs (updated)
-----
src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
Diff: https://reviews.apache.org/r/58320/diff/3/
Changes: https://reviews.apache.org/r/58320/diff/2-3/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 58320: Added an upgrade test for executor
authentication.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/
-----------------------------------------------------------
(Updated April 11, 2017, 4:46 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
ensures that an executor which is launched with the
'--executor_secret_key' flag set but the
'--authenticate_http_executors' flag not set will be able to
subscribe successfully after the agent is restarted with the
'--authenticate_http_executors' flag set.
Diffs (updated)
-----
src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2
Diff: https://reviews.apache.org/r/58320/diff/2/
Changes: https://reviews.apache.org/r/58320/diff/1-2/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann