You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mdudek <gi...@git.apache.org> on 2014/10/23 16:32:20 UTC
[GitHub] cordova-plugin-splashscreen pull request: Fixed SplashScreenProxy....
GitHub user mdudek opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/31
Fixed SplashScreenProxy.js
Fixed exception when hide() method is called multiple times.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mdudek/cordova-plugin-splashscreen patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 24b20e2b820044dd7eb9a7cfb39a0471d9cb4ff9
Author: Michael Dudek <mi...@centrum.cz>
Date: 2014-10-23T14:31:13Z
Updated SplashScreenProxy.js - fixed exception when hide() method is called multiple times.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed SplashScreenProxy....
Posted by mdudek <gi...@git.apache.org>.
Github user mdudek closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed SplashScreenProxy....
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/31#issuecomment-164781480
Hello @mdudek,
Thanks for your contribution!
Looks like it is already [implemented in master](https://github.com/apache/cordova-plugin-splashscreen/blob/9ea2d4c86f07bd2be449d06c31ab30960bc24c47/www/windows/SplashScreenProxy.js#L70) - could you please close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org