[GitHub] [incubator-uniffle] advancedxy commented on pull request #812: [#778] feat: Separate `ShuffleServer` metrics through tags

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#issuecomment-1503116574

   @smallzhongfeng Thanks for your work.. When I'm working on https://github.com/apache/incubator-uniffle/issues/793, I made similar changes. However it seems too much changes and it was primary to label cluster name and I thought it wasn't worth it.
   
   Do you have some more input for this one? I'm OK to accept this PR with some comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org