You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/17 22:20:39 UTC
[GitHub] [flink] afedulov opened a new pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
afedulov opened a new pull request #19139:
URL: https://github.com/apache/flink/pull/19139
## What is the purpose of the change
PostgreSQL tests were executed based on an embedded database. This has issues on some systems (Mac) and blocked work on FLINK-25926. This PR migrates these tests to Testcontainers.
## Verifying this change
This PR modifies the existing tests setup.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072211241
@afedulov I can confirm that I can run the tests locally and see the testcontainer spinning up. When the version is set at the right location, we can merge this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66723c1a63fc84db21d8754a4eb60b20509896de Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275)
* 33be171b4509b3d4c677001ba624ec74b3c3c60a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33be171b4509b3d4c677001ba624ec74b3c3c60a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "1072655137",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7731c33a895c8368a33373349798f93cb22a7ac3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072224405
@afedulov One more comment when I was running all tests for JDBC: `JdbcCatalogFactoryTest` doesn't seem to use testcontainers, because that failed locally with
```
java.lang.IllegalStateException: Process [/var/folders/vy/p3hq5hts1wlbs4ycpxj82p5r0000gn/T/embedded-pg/PG-578c3302bce806451b07e3a73d8438d1/bin/initdb, -A, trust, -U, postgres, -D, /var/folders/vy/p3hq5hts1wlbs4ycpxj82p5r0000gn/T/epg7902155988816586497, -E, UTF-8] failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072655137
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66723c1a63fc84db21d8754a4eb60b20509896de Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275)
* 33be171b4509b3d4c677001ba624ec74b3c3c60a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342)
* 55fda9e49a8540391a56145e281d035ceeede8f4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19139:
URL: https://github.com/apache/flink/pull/19139#discussion_r829780185
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -37,9 +40,12 @@
/** Test base for {@link PostgresCatalog}. */
public class PostgresCatalogTestBase {
+ public static final Logger LOG = LoggerFactory.getLogger(PostgresCatalogTestBase.class);
+
@Rule public ExpectedException exception = ExpectedException.none();
- @ClassRule public static SingleInstancePostgresRule pg = EmbeddedPostgresRules.singleInstance();
+ protected static final DockerImageName POSTGRES_96_IMAGE =
+ DockerImageName.parse("postgres:9.6.12");
Review comment:
We should define the used version like the others in https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072283175
Thanks, @MartijnVisser. I migrated the failing test to Testcontainers too. Please check if it works for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "1072655137",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66723c1a63fc84db21d8754a4eb60b20509896de Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275)
* 33be171b4509b3d4c677001ba624ec74b3c3c60a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7731c33a895c8368a33373349798f93cb22a7ac3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7731c33a895c8368a33373349798f93cb22a7ac3 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273)
* 66723c1a63fc84db21d8754a4eb60b20509896de Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66723c1a63fc84db21d8754a4eb60b20509896de Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7731c33a895c8368a33373349798f93cb22a7ac3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273)
* 66723c1a63fc84db21d8754a4eb60b20509896de UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072312038
I can now do a full `mvn clean install` on the JDBC connector, so looks good! :)
One more thing: I think we should now be able to remove the embedded PG dependency, so remove https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/pom.xml#L41 and https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/pom.xml#L128-L133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072283175
Thanks, @MartijnVisser. I migrated the failing test to Testcontainers too. Please check if it works for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33be171b4509b3d4c677001ba624ec74b3c3c60a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342)
* 55fda9e49a8540391a56145e281d035ceeede8f4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged pull request #19139:
URL: https://github.com/apache/flink/pull/19139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "1072655137",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19139:
URL: https://github.com/apache/flink/pull/19139#discussion_r829780185
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -37,9 +40,12 @@
/** Test base for {@link PostgresCatalog}. */
public class PostgresCatalogTestBase {
+ public static final Logger LOG = LoggerFactory.getLogger(PostgresCatalogTestBase.class);
+
@Rule public ExpectedException exception = ExpectedException.none();
- @ClassRule public static SingleInstancePostgresRule pg = EmbeddedPostgresRules.singleInstance();
+ protected static final DockerImageName POSTGRES_96_IMAGE =
+ DockerImageName.parse("postgres:9.6.12");
Review comment:
We should define the used version like the others in https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33273",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
}, {
"hash" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33275",
"triggerID" : "66723c1a63fc84db21d8754a4eb60b20509896de",
"triggerType" : "PUSH"
}, {
"hash" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342",
"triggerID" : "33be171b4509b3d4c677001ba624ec74b3c3c60a",
"triggerType" : "PUSH"
}, {
"hash" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354",
"triggerID" : "55fda9e49a8540391a56145e281d035ceeede8f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33be171b4509b3d4c677001ba624ec74b3c3c60a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33342)
* 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1072211241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7731c33a895c8368a33373349798f93cb22a7ac3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7731c33a895c8368a33373349798f93cb22a7ac3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org