[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8557: Added live reports for Kafka and Native batch task (#899)

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #8557: Added live reports for Kafka and Native batch task (#899)
URL: https://github.com/apache/incubator-druid/pull/8557#discussion_r326293876
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
 ##########
 @@ -638,6 +638,50 @@ public InputStream openStream() throws IOException
     }
   }
 
+  @Override
+  public Optional<ByteSource> streamTaskReports(final String taskId)
+  {
+    final ZkWorker zkWorker = findWorkerRunningTask(taskId);
+
+    if (zkWorker == null) {
+      // Worker is not running this task, it might be available in deep storage
+      return Optional.absent();
+    } else {
+      // Worker is still running this task
+      Worker worker = runningTasks.get(taskId).getWorker();
 
 Review comment:
   Spotbugs is flagging this line:
   ```
   [ERROR] Dead store to worker in org.apache.druid.indexing.overlord.RemoteTaskRunner.streamTaskReports(String) [org.apache.druid.indexing.overlord.RemoteTaskRunner] At RemoteTaskRunner.java:[line 651] DLS_DEAD_LOCAL_STORE
   ```
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org