[jira] [Commented] (YARN-1018) prereqeq check for AMRMClient.ContainerRequest relaxLocality flag wrong

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727666#comment-13727666 ] 

Steve Loughran commented on YARN-1018:
--------------------------------------

{code}
java.lang.IllegalArgumentException: Can't turn off locality relaxation on a request with no location constraints
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
	at org.apache.hadoop.yarn.client.api.AMRMClient$ContainerRequest.<init>(AMRMClient.java:149)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:77)
{code}

Looks to me like an extra {{!}} in the (complex) validator
{code}
      Preconditions.checkArgument(
              !(!relaxLocality && (racks == null || racks.length == 0) 
                  && (nodes == null || nodes.length == 0)),
              "Can't turn off locality relaxation on a " + 
              "request with no location constraints");
{code}

I think this probe should be skipped altogether. If someone asks for a relaxed priority and there no racks or nodes it should be downgraded to a no-op & not rejected.


                
> prereqeq check for AMRMClient.ContainerRequest relaxLocality flag wrong
> -----------------------------------------------------------------------
>
>                 Key: YARN-1018
>                 URL: https://issues.apache.org/jira/browse/YARN-1018
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.1.0-beta
>            Reporter: Steve Loughran
>            Priority: Minor
>
> Trying to create a container request with no racks/nodes and no relaxed priority fails
> {code}
> new AMRMClient.ContainerRequest(capability, null, null, 0, false);
> {code}
> expected: a container request.
> actual: stack trace saying I can't relax node locality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira