You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@slider.apache.org by "Billie Rinaldi (JIRA)" <ji...@apache.org> on 2016/12/13 15:48:58 UTC

[jira] [Commented] (SLIDER-1179) app-package path should be verified when running “slider upgrade”

    [ https://issues.apache.org/jira/browse/SLIDER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745460#comment-15745460 ] 

Billie Rinaldi commented on SLIDER-1179:
----------------------------------------

App def validation should be performed in AgentClientProvider.validateInstanceDefinition. This is called at the end of buildInstanceDefinition. I see a comment there "TODO: Validation should be done before persistence," but I do not know why it is currently being performed after persistence. In any case, validation is already happening in the client. Is that not what you are seeing?

> app-package path should be verified when running “slider upgrade” 
> ------------------------------------------------------------------
>
>                 Key: SLIDER-1179
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1179
>             Project: Slider
>          Issue Type: Improvement
>            Reporter: kyungwan nam
>         Attachments: SLIDER-1179.patch
>
>
> slider app is failed when running “slider upgrade” with appConfig including invalid “application.def”
> i think it should be verified in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)