You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/02/26 21:33:58 UTC
Review Request 31493: Upgrading JMH plugin and framework versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31493/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Updating jmh plugin to 0.2.0: https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt
The most notable is the fix to support `jmhVersion` attribute that allowed to bump up jmh version from 1.3.2 to current 1.6.1.
JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/
Among multiple improvements and stability fixes there is also https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of:
```
warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7'
```
Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed peak usage of 600Mb).
Diffs
-----
build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248
Diff: https://reviews.apache.org/r/31493/diff/
Testing
-------
./gradlew jmh
Thanks,
Maxim Khutornenko
Re: Review Request 31493: Upgrading JMH plugin and framework versions.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31493/#review74516
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Feb. 26, 2015, 8:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31493/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 8:33 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Updating jmh plugin to 0.2.0: https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt
>
> The most notable is the fix to support `jmhVersion` attribute that allowed to bump up jmh version from 1.3.2 to current 1.6.1.
>
>
> JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/
>
> Among multiple improvements and stability fixes there is also https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of:
> ```
> warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7'
> ```
>
> Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed peak usage of 600Mb).
>
>
> Diffs
> -----
>
> build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248
>
> Diff: https://reviews.apache.org/r/31493/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31493: Upgrading JMH plugin and framework versions.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31493/#review74361
-----------------------------------------------------------
Ship it!
Master (36af017) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2015, 8:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31493/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 8:33 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Updating jmh plugin to 0.2.0: https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt
>
> The most notable is the fix to support `jmhVersion` attribute that allowed to bump up jmh version from 1.3.2 to current 1.6.1.
>
>
> JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/
>
> Among multiple improvements and stability fixes there is also https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of:
> ```
> warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7'
> ```
>
> Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed peak usage of 600Mb).
>
>
> Diffs
> -----
>
> build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248
>
> Diff: https://reviews.apache.org/r/31493/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>