Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/

[Stefan Sperling <st...@elego.de>]

On Wed, Apr 18, 2012 at 12:33:23PM -0000, stefan2@apache.org wrote:
> Author: stefan2
> Date: Wed Apr 18 12:33:23 2012
> New Revision: 1327477
> 
> URL: http://svn.apache.org/viewvc?rev=1327477&view=rev
> Log:
> Naming policy: Rename all svn_*.c to just *.c in /subversion/libsvn_subr.

Was there a very important reason for this change?
This change can cause tree-conflicts during backports that affect
these files. It's not likely to cause a lot of harm since we're
looking at a small amount of files that rarely receive backport
changes. Still, a heads-up or question about concerns on dev@ would
have been nice since this creates extra work during backports
for no apparent gain.

A minor nit: You forgot to list svn_temp_serializer.c in the log message.

> 
> added:
> * /subversion/libsvn_subr/base64.c
> * /subversion/libsvn_subr/cache_config.c
> * /subversion/libsvn_subr/mutex.c
> * /subversion/libsvn_subr/named_atomic.c
> * /subversion/libsvn_subr/string.c
> removed:
> * /subversion/libsvn_subr/svn_base64.c
> * /subversion/libsvn_subr/svn_cache_config.c
> * /subversion/libsvn_subr/svn_mutex.c
> * /subversion/libsvn_subr/svn_named_atomic.c
> * /subversion/libsvn_subr/svn_string.c
> 
> Added:
>     subversion/trunk/subversion/libsvn_subr/base64.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_base64.c
>     subversion/trunk/subversion/libsvn_subr/cache_config.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_cache_config.c
>     subversion/trunk/subversion/libsvn_subr/mutex.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_mutex.c
>     subversion/trunk/subversion/libsvn_subr/named_atomic.c
>       - copied unchanged from r1327472, subversion/trunk/subversion/libsvn_subr/svn_named_atomic.c
>     subversion/trunk/subversion/libsvn_subr/string.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_string.c
>     subversion/trunk/subversion/libsvn_subr/temp_serializer.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_temp_serializer.c
>     subversion/trunk/subversion/libsvn_subr/types.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_types.c
> Removed:
>     subversion/trunk/subversion/libsvn_subr/svn_base64.c
>     subversion/trunk/subversion/libsvn_subr/svn_cache_config.c
>     subversion/trunk/subversion/libsvn_subr/svn_mutex.c
>     subversion/trunk/subversion/libsvn_subr/svn_named_atomic.c
>     subversion/trunk/subversion/libsvn_subr/svn_string.c
>     subversion/trunk/subversion/libsvn_subr/svn_temp_serializer.c
>     subversion/trunk/subversion/libsvn_subr/svn_types.c

Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/

[Stefan Fuhrmann <eq...@web.de>]

Am 18.04.2012 21:41, schrieb Greg Stein:
> On Wed, Apr 18, 2012 at 14:22, Stefan Sperling<st...@elego.de>  wrote:
>> On Wed, Apr 18, 2012 at 12:33:23PM -0000, stefan2@apache.org wrote:
>>> Author: stefan2
>>> Date: Wed Apr 18 12:33:23 2012
>>> New Revision: 1327477
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1327477&view=rev
>>> Log:
>>> Naming policy: Rename all svn_*.c to just *.c in /subversion/libsvn_subr.
>> Was there a very important reason for this change?
> It was in response to a commit review where Hyrum noted the "svn_"
> prefix is redundant.
>
>> This change can cause tree-conflicts during backports that affect
>> these files. It's not likely to cause a lot of harm since we're
>> looking at a small amount of files that rarely receive backport
>> changes. Still, a heads-up or question about concerns on dev@ would
>> have been nice since this creates extra work during backports
>> for no apparent gain.
Sorry for that. I had Hyrum's post in mind and searched
for affected files. Then I realized that the majority were
"mine" and the others were basic / stable ones. Since
1.7 has had a number of bugfix releases already, the
probability for urgent backports should be relatively low.

So, I went for the rename. If that causes backport problems,
feel free to ask me to do the merge.
> I applaud the corrected names :-P
>
>> A minor nit: You forgot to list svn_temp_serializer.c in the log message.
> And svn_types.c
Fixed.

-- Stefan^2.

Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/

[Greg Stein <gs...@gmail.com>]

On Wed, Apr 18, 2012 at 14:22, Stefan Sperling <st...@elego.de> wrote:
> On Wed, Apr 18, 2012 at 12:33:23PM -0000, stefan2@apache.org wrote:
>> Author: stefan2
>> Date: Wed Apr 18 12:33:23 2012
>> New Revision: 1327477
>>
>> URL: http://svn.apache.org/viewvc?rev=1327477&view=rev
>> Log:
>> Naming policy: Rename all svn_*.c to just *.c in /subversion/libsvn_subr.
>
> Was there a very important reason for this change?

It was in response to a commit review where Hyrum noted the "svn_"
prefix is redundant.

> This change can cause tree-conflicts during backports that affect
> these files. It's not likely to cause a lot of harm since we're
> looking at a small amount of files that rarely receive backport
> changes. Still, a heads-up or question about concerns on dev@ would
> have been nice since this creates extra work during backports
> for no apparent gain.

I applaud the corrected names :-P

>
> A minor nit: You forgot to list svn_temp_serializer.c in the log message.

And svn_types.c

Cheers,
-g