You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 23:04:31 UTC
Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Navbar now requires the class "navbar-inverse" to stay black.
This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
Diffs
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
Diff: https://reviews.apache.org/r/12288/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/#review22829
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 5, 2013, 11:01 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12288/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 11:01 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Navbar now requires the class "navbar-inverse" to stay black.
>
> This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
> src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
>
> Diff: https://reviews.apache.org/r/12288/diff/
>
>
> Testing
> -------
>
> Rendered all pages of the site to confirm no UI breakage with the new CSS.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ross Allen <re...@gmail.com>.
> On July 8, 2013, 7:44 p.m., Ben Mahler wrote:
> > src/Makefile.am, lines 410-411
> > <https://reviews.apache.org/r/12288/diff/1/?file=318393#file318393line410>
> >
> > Can you align the backslashes here with the rest of them?
> >
> > Also, do you foresee wanting to look at the non-minified css when you're debugging or playing with the webui? If so, we should probably include them, as we do with the js libraries. At least, for js newbies like myself, it has proven pretty useful!
I have never had a reason to look at raw CSS files since Chrome and Firefox dev tools do such a great job of letting you inspect and modify CSS rules. Have you found them useful?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/#review22849
-----------------------------------------------------------
On July 8, 2013, 9:27 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12288/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 9:27 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Navbar now requires the class "navbar-inverse" to stay black.
>
> This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
> src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
>
> Diff: https://reviews.apache.org/r/12288/diff/
>
>
> Testing
> -------
>
> Rendered all pages of the site to confirm no UI breakage with the new CSS.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ben Mahler <be...@gmail.com>.
> On July 8, 2013, 7:44 p.m., Ben Mahler wrote:
> > src/Makefile.am, lines 410-411
> > <https://reviews.apache.org/r/12288/diff/1/?file=318393#file318393line410>
> >
> > Can you align the backslashes here with the rest of them?
> >
> > Also, do you foresee wanting to look at the non-minified css when you're debugging or playing with the webui? If so, we should probably include them, as we do with the js libraries. At least, for js newbies like myself, it has proven pretty useful!
>
> Ross Allen wrote:
> I have never had a reason to look at raw CSS files since Chrome and Firefox dev tools do such a great job of letting you inspect and modify CSS rules. Have you found them useful?
Nope, just wanted to hear your thoughts!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/#review22849
-----------------------------------------------------------
On July 8, 2013, 9:27 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12288/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 9:27 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Navbar now requires the class "navbar-inverse" to stay black.
>
> This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
> src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
>
> Diff: https://reviews.apache.org/r/12288/diff/
>
>
> Testing
> -------
>
> Rendered all pages of the site to confirm no UI breakage with the new CSS.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/#review22849
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/12288/#comment46584>
Can you align the backslashes here with the rest of them?
Also, do you foresee wanting to look at the non-minified css when you're debugging or playing with the webui? If so, we should probably include them, as we do with the js libraries. At least, for js newbies like myself, it has proven pretty useful!
- Ben Mahler
On July 5, 2013, 11:01 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12288/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 11:01 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Navbar now requires the class "navbar-inverse" to stay black.
>
> This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
> src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
>
> Diff: https://reviews.apache.org/r/12288/diff/
>
>
> Testing
> -------
>
> Rendered all pages of the site to confirm no UI breakage with the new CSS.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/#review22869
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 8, 2013, 9:27 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12288/
> -----------------------------------------------------------
>
> (Updated July 8, 2013, 9:27 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Navbar now requires the class "navbar-inverse" to stay black.
>
> This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
> src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
> src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
>
> Diff: https://reviews.apache.org/r/12288/diff/
>
>
> Testing
> -------
>
> Rendered all pages of the site to confirm no UI breakage with the new CSS.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/
-----------------------------------------------------------
(Updated July 8, 2013, 9:27 p.m.)
Review request for mesos.
Changes
-------
Align slahes in Makefile.am for real
Mixed spaces and tabs are gnarly to maintain.
Repository: mesos
Description
-------
Navbar now requires the class "navbar-inverse" to stay black.
This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
Diffs (updated)
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
Diff: https://reviews.apache.org/r/12288/diff/
Testing
-------
Rendered all pages of the site to confirm no UI breakage with the new CSS.
Thanks,
Ross Allen
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/
-----------------------------------------------------------
(Updated July 8, 2013, 9:25 p.m.)
Review request for mesos.
Changes
-------
Align slashes in Makefile.am.
Repository: mesos
Description
-------
Navbar now requires the class "navbar-inverse" to stay black.
This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
Diffs (updated)
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
Diff: https://reviews.apache.org/r/12288/diff/
Testing
-------
Rendered all pages of the site to confirm no UI breakage with the new CSS.
Thanks,
Ross Allen
Re: Review Request 12288: Upgrade Bootstrap CSS to v2.3.2
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12288/
-----------------------------------------------------------
(Updated July 5, 2013, 11:01 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Navbar now requires the class "navbar-inverse" to stay black.
This is done in preparation for introducing Angular UI Bootstrap (http://angular-ui.github.io/bootstrap/).
Diffs
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css PRE-CREATION
src/webui/master/static/bootstrap/css/bootstrap-responsive.css 7f669d573fb1b27a0354f62007669e30d408510b
src/webui/master/static/bootstrap/css/bootstrap.css 09e2833dcdefc4d7eededbcea0dabba19af1b356
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
Diff: https://reviews.apache.org/r/12288/diff/
Testing (updated)
-------
Rendered all pages of the site to confirm no UI breakage with the new CSS.
Thanks,
Ross Allen