[GitHub] spark pull request #18092: [SPARK-20640][CORE]Make rpc timeout and retry for...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18092#discussion_r118547246
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -170,11 +170,17 @@ private[spark] class BlockManager(
       // service, or just our own Executor's BlockManager.
       private[spark] var shuffleServerId: BlockManagerId = _
     
    +  private val registrationTimeout =
    +    conf.getTimeAsMs("spark.shuffle.registration.timeout", "5s")
    --- End diff --
    
    For new configurations, should we be putting these into the `config` package object? See https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/config/package.scala and https://github.com/apache/spark/pull/10205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org