You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/10 20:33:04 UTC

[jira] [Commented] (TC-180) docker-compose build file structure is a bit messy

    [ https://issues.apache.org/jira/browse/TC-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905659#comment-15905659 ] 

ASF GitHub Bot commented on TC-180:
-----------------------------------

GitHub user alficles opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/347

    Add global build script.

    This splits out the somewhat messy docker build command into its own script and adds a global build script.
    There’s still work to be done to clean up docker build scripts, but this provides a basic way to build top to bottom
    In a single, simple command.
    
    This is a step toward addressing TC-180, but falls short of cleaning up everything that requires cleaning up.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alficles/incubator-trafficcontrol global-build-script

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #347
    
----
commit 64e18cb57756ed995adc29ab8018abb1d60e73d6
Author: Chris Lemmons <al...@gmail.com>
Date:   2017-03-10T18:18:57Z

    Add global build script.
    
    This splits out the somewhat messy docker build command into its own script and adds a global build script.
    There’s still work to be done to clean up docker build scripts, but this provides a basic way to build top to bottom
    In a single, simple command.
    
    This is a step toward addressing TC-180, but falls short of cleaning up everything that requires cleaning up.

commit 0eb9eddc1b850a8adb934e6b5cc48511fb7ac672
Author: Chris Lemmons <al...@gmail.com>
Date:   2017-03-10T20:20:51Z

    Updated default build instructions to refer to the build script.

----


> docker-compose build file structure is a bit messy
> --------------------------------------------------
>
>                 Key: TC-180
>                 URL: https://issues.apache.org/jira/browse/TC-180
>             Project: Traffic Control
>          Issue Type: Improvement
>          Components: all
>    Affects Versions: 2.0.0
>            Reporter: Dan Kirkwood
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> Need to come up with a cleaner build structure -- currently in infrastructure/docker/build/* so initial build command is a little daunting..



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)