You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2014/01/29 00:45:15 UTC

svn commit: r1562314 - /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java

Author: apurtell
Date: Tue Jan 28 23:45:14 2014
New Revision: 1562314

URL: http://svn.apache.org/r1562314
Log:
HBASE-10429 Make Visibility Controller to throw a better msg if it is of type RegionServerCoprocessor (Ramkrishna S. Vasudevan)

Modified:
    hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java

Modified: hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java?rev=1562314&r1=1562313&r2=1562314&view=diff
==============================================================================
--- hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java (original)
+++ hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java Tue Jan 28 23:45:14 2014
@@ -71,6 +71,7 @@ import org.apache.hadoop.hbase.coprocess
 import org.apache.hadoop.hbase.coprocessor.ObserverContext;
 import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
 import org.apache.hadoop.hbase.coprocessor.RegionObserver;
+import org.apache.hadoop.hbase.coprocessor.RegionServerCoprocessorEnvironment;
 import org.apache.hadoop.hbase.exceptions.DeserializationException;
 import org.apache.hadoop.hbase.filter.Filter;
 import org.apache.hadoop.hbase.filter.FilterList;
@@ -178,6 +179,10 @@ public class VisibilityController extend
       // if running at region
       regionEnv = (RegionCoprocessorEnvironment) env;
       zk = regionEnv.getRegionServerServices().getZooKeeper();
+    } else if (env instanceof RegionServerCoprocessorEnvironment) {
+      throw new RuntimeException(
+          "Visibility controller should not be configured as " +
+          "'hbase.coprocessor.regionserver.classes'.");
     }
 
     // If zk is null or IOException while obtaining auth manager,