You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/02/07 16:21:11 UTC

[GitHub] [incubator-ratis] errose28 commented on a change in pull request #420: RATIS-1305. Leader stuck in infinite install snapshot cycle when logs have been purged

errose28 commented on a change in pull request #420:
URL: https://github.com/apache/incubator-ratis/pull/420#discussion_r571641628



##########
File path: ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -562,17 +562,23 @@ private void installSnapshot(TermIndex firstAvailableLogTermIndex) {
    * @return the first available log's start term index
    */
   private TermIndex shouldNotifyToInstallSnapshot() {
-    final long leaderStartIndex = getRaftLog().getStartIndex();

Review comment:
       Changed code to the proposed suggestion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org