You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/10 23:45:49 UTC
[GitHub] [dubbo-samples] zhangxin1932 opened a new pull request #283: 复现只有一台provider 时, MergeableClusterInvoker 的bug
zhangxin1932 opened a new pull request #283:
URL: https://github.com/apache/dubbo-samples/pull/283
复现只有一台provider 时, MergeableClusterInvoker 的bug, for dubbo issues:
to fix something wrong with MergeableClusterInvoker #7359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zhangxin1932 commented on a change in pull request #283: 复现只有一台provider 时, MergeableClusterInvoker 的bug
Posted by GitBox <gi...@apache.org>.
zhangxin1932 commented on a change in pull request #283:
URL: https://github.com/apache/dubbo-samples/pull/283#discussion_r598743958
##########
File path: dubbo-samples-merge/dubbo-samples-merge-consumer/src/main/java/org/apache/dubbo/samples/merge/DubboConsumer.java
##########
@@ -0,0 +1,14 @@
+package org.apache.dubbo.samples.merge;
+
+import org.apache.dubbo.samples.merge.api.IDubboService;
+import org.springframework.context.support.ClassPathXmlApplicationContext;
+
+public class DubboConsumer {
+ public static void main(String[] args) throws Exception {
+ ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("spring/dubbo-consumer.xml");
+ context.start();
+
+ IDubboService dubboService = (IDubboService) context.getBean("dubboService");
Review comment:
yeah, a file which was commited a few minutes ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] zhangxin1932 commented on a change in pull request #283: 复现只有一台provider 时, MergeableClusterInvoker 的bug
Posted by GitBox <gi...@apache.org>.
zhangxin1932 commented on a change in pull request #283:
URL: https://github.com/apache/dubbo-samples/pull/283#discussion_r598210290
##########
File path: dubbo-samples-merge/dubbo-samples-merge-provider1/src/main/resources/spring/merge-provider.xml
##########
@@ -25,7 +25,7 @@
<dubbo:application name="merge-provider-1"/>
- <dubbo:registry address="zookeeper://${zookeeper.address:127.0.0.1}:2181"/>
+ <dubbo:registry address="zookeeper://${zookeeper.address:192.168.0.156}:2181"/>
Review comment:
ok, the address of zk had been reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ commented on a change in pull request #283: 复现只有一台provider 时, MergeableClusterInvoker 的bug
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #283:
URL: https://github.com/apache/dubbo-samples/pull/283#discussion_r594081477
##########
File path: dubbo-samples-merge/dubbo-samples-merge-provider1/src/main/resources/spring/merge-provider.xml
##########
@@ -25,7 +25,7 @@
<dubbo:application name="merge-provider-1"/>
- <dubbo:registry address="zookeeper://${zookeeper.address:127.0.0.1}:2181"/>
+ <dubbo:registry address="zookeeper://${zookeeper.address:192.168.0.156}:2181"/>
Review comment:
pls not change this address, which will cause address problem for other users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ commented on a change in pull request #283: 复现只有一台provider 时, MergeableClusterInvoker 的bug
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #283:
URL: https://github.com/apache/dubbo-samples/pull/283#discussion_r598371138
##########
File path: dubbo-samples-merge/dubbo-samples-merge-consumer/src/main/java/org/apache/dubbo/samples/merge/DubboConsumer.java
##########
@@ -0,0 +1,14 @@
+package org.apache.dubbo.samples.merge;
+
+import org.apache.dubbo.samples.merge.api.IDubboService;
+import org.springframework.context.support.ClassPathXmlApplicationContext;
+
+public class DubboConsumer {
+ public static void main(String[] args) throws Exception {
+ ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("spring/dubbo-consumer.xml");
+ context.start();
+
+ IDubboService dubboService = (IDubboService) context.getBean("dubboService");
Review comment:
Pls convert this case to integration test so it can verify automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org