You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/06 22:24:49 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #9420: KAFKA-10604: The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

vvcephei commented on a change in pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#discussion_r552994981



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -602,7 +603,7 @@
                     REPLICATION_FACTOR_DOC)
             .define(STATE_DIR_CONFIG,
                     Type.STRING,
-                    "/tmp/kafka-streams",
+                    Utils.getTempDir().resolve("kafka-streams").toAbsolutePath().toString(),

Review comment:
       Thanks for this @dongjinleekr !
   
   It's kind of a bummer that we actually create this file while defining the configurations, since it results in leaking temp directories, even if users set this config to a different value.
   
   Do you think we can do this in a lazy fashion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org