You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2026/10/10 03:12:27 UTC

[PR] [fix](regression) Restore missing ES query results on branch-4.1 [doris]

Gabriel39 opened a new pull request, #68852:
URL: https://github.com/apache/doris/pull/68852

   ### What problem does this PR solve?
   
   Related PR: #66425
   
   `test_es_query` fails with `Missing output block for tag 'sql01'` because its expected output lost all 18 external-table query blocks in each of the two scroll-mode passes during an output refresh.
   
   Restore the 36 missing blocks verbatim from the generated baseline before commit `78c1626259`, in their original positions. The query SQL is unchanged, and all existing catalog results, including their updated floating-point formatting, are preserved. Add a comment documenting that both query groups need results for each scroll mode.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test:
     - [x] Manual test: compiled the suite with Groovy 4.0.19 and exercised the regression framework's actual `OutputUtils.iterator` using all query tags in execution order for both scroll modes. Before the fix it fails at `sql01`; after the fix it parses all 312 blocks and 1,002 rows.
     - [x] Verified restored blocks match the historical generated baseline byte for byte and all 156 query SQL statements are unchanged.
     - [x] `git diff --check`
     - Full Doris/Elasticsearch integration execution was not run locally.
   - Behavior changed: No product behavior change; restores regression result checking.
   - Does this need documentation: No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](regression) Restore missing ES query results on branch-4.1 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68852:
URL: https://github.com/apache/doris/pull/68852#issuecomment-6093182892

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](regression) Restore missing ES query results on branch-4.1 [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #68852:
URL: https://github.com/apache/doris/pull/68852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](regression) Restore missing ES query results on branch-4.1 [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #68852:
URL: https://github.com/apache/doris/pull/68852#issuecomment-6093184271

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](regression) Restore missing ES query results on branch-4.1 [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #68852:
URL: https://github.com/apache/doris/pull/68852#issuecomment-6093185200

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org