You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2013/05/10 03:27:46 UTC
git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486
propsedSeletedItemIndexes[uid] is undefined otherwise
Updated Branches:
refs/heads/develop 670532045 -> 6838f9595
FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6838f959
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6838f959
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6838f959
Branch: refs/heads/develop
Commit: 6838f95954afc32ba7a9404a454ce8aac5846de5
Parents: 6705320
Author: Justin Mclean <jm...@apache.org>
Authored: Fri May 10 11:26:47 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Fri May 10 11:26:47 2013 +1000
----------------------------------------------------------------------
.../mx/src/mx/controls/listClasses/ListBase.as | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6838f959/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
index 238d8e8..4e5c49d 100644
--- a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
+++ b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
@@ -7395,7 +7395,7 @@ public class ListBase extends ScrollControlBase
item = items[i];
if (compareFunction(data, item))
{
- uid = itemToUID(data);
+ uid = itemToUID(item);
selectionDataArray[proposedSelectedItemIndexes[uid]] = new ListBaseSelectionData(data, index, false);
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Just happened to notice and wonder: If you are changing from getting the
> uid from the data to getting the uid from the item, shoud the
> ListSelectionData on the next line be associated with the item instead of
> data?
You think so but that' s not the case. It was my first thought as well. I tried that change but it didn't work. In the code the term data and item is used interchangeably which probably caused the confusion/problem in the first place. However still may be other places where it is incorrect.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486
propsedSeletedItemIndexes[uid] is undefined otherwise
Posted by Alex Harui <ah...@adobe.com>.
Just happened to notice and wonder: If you are changing from getting the
uid from the data to getting the uid from the item, shoud the
ListSelectionData on the next line be associated with the item instead of
data?
On 5/9/13 6:27 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
> Updated Branches:
> refs/heads/develop 670532045 -> 6838f9595
>
>
> FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6838f959
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6838f959
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6838f959
>
> Branch: refs/heads/develop
> Commit: 6838f95954afc32ba7a9404a454ce8aac5846de5
> Parents: 6705320
> Author: Justin Mclean <jm...@apache.org>
> Authored: Fri May 10 11:26:47 2013 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Fri May 10 11:26:47 2013 +1000
>
> ----------------------------------------------------------------------
> .../mx/src/mx/controls/listClasses/ListBase.as | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6838f959/frameworks/proje
> cts/mx/src/mx/controls/listClasses/ListBase.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> index 238d8e8..4e5c49d 100644
> --- a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> +++ b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> @@ -7395,7 +7395,7 @@ public class ListBase extends ScrollControlBase
> item = items[i];
> if (compareFunction(data, item))
> {
> - uid = itemToUID(data);
> + uid = itemToUID(item);
>
> selectionDataArray[proposedSelectedItemIndexes[uid]]
> = new ListBaseSelectionData(data, index, false);
>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486
propsedSeletedItemIndexes[uid] is undefined otherwise
Posted by Alex Harui <ah...@adobe.com>.
Just happened to notice and wonder: If you are changing from getting the
uid from the data to getting the uid from the item, shoud the
ListSelectionData on the next line be associated with the item instead of
data?
On 5/9/13 6:27 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
> Updated Branches:
> refs/heads/develop 670532045 -> 6838f9595
>
>
> FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6838f959
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6838f959
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6838f959
>
> Branch: refs/heads/develop
> Commit: 6838f95954afc32ba7a9404a454ce8aac5846de5
> Parents: 6705320
> Author: Justin Mclean <jm...@apache.org>
> Authored: Fri May 10 11:26:47 2013 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Fri May 10 11:26:47 2013 +1000
>
> ----------------------------------------------------------------------
> .../mx/src/mx/controls/listClasses/ListBase.as | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6838f959/frameworks/proje
> cts/mx/src/mx/controls/listClasses/ListBase.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> index 238d8e8..4e5c49d 100644
> --- a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> +++ b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
> @@ -7395,7 +7395,7 @@ public class ListBase extends ScrollControlBase
> item = items[i];
> if (compareFunction(data, item))
> {
> - uid = itemToUID(data);
> + uid = itemToUID(item);
>
> selectionDataArray[proposedSelectedItemIndexes[uid]]
> = new ListBaseSelectionData(data, index, false);
>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui