You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by ca...@apache.org on 2018/11/23 09:07:49 UTC
svn commit: r1847225 - in /jackrabbit/oak/branches/1.8: ./
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java
oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java
Author: catholicon
Date: Fri Nov 23 09:07:49 2018
New Revision: 1847225
URL: http://svn.apache.org/viewvc?rev=1847225&view=rev
Log:
OAK-7808: Incorrect facet counts when some results are inaccessible due to ACLs (backport r1843175 from trunk)
Modified:
jackrabbit/oak/branches/1.8/ (props changed)
jackrabbit/oak/branches/1.8/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java
jackrabbit/oak/branches/1.8/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java
Propchange: jackrabbit/oak/branches/1.8/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Nov 23 09:07:49 2018
@@ -1,3 +1,3 @@
/jackrabbit/oak/branches/1.0:1665962
-/jackrabbit/oak/trunk:1820660-1820661,1820729,1820734,1820859,1820861,1820878,1820888,1820947,1821027,1821130,1821140-1821141,1821178,1821237,1821240,1821249,1821258,1821325,1821358,1821361-1821362,1821370,1821375,1821393,1821477,1821487,1821516,1821617,1821663,1821665,1821668,1821681,1821847,1821975-1821983,1822121,1822201,1822207,1822527,1822642,1822723,1822808,1822850,1822934,1823135,1823163,1823169,1823172,1823655,1823669,1824196,1824198,1824253,1824255,1824896,1824962,1825065,1825362,1825381,1825442,1825448,1825466,1825470-1825471,1825475,1825523,1825525,1825561,1825619-1825621,1825651,1825654,1825992,1826079,1826090,1826096,1826216,1826237,1826338,1826516,1826532,1826551,1826560,1826638,1826640,1826730,1826833,1826932,1826957,1827423,1827472,1827486,1827816,1827977,1828349,1828439,1828502,1828529,1828948,1829527,1829534,1829546,1829569,1829587,1829665,1829854,1829864,1829978,1829985,1829987,1829998,1830019,1830048,1830160,1830171,1830197,1830209,1830239,1830347,1830748,1830911
,1830923,1831157-1831158,1831163,1831190,1831374,1831560,1831689,1832258,1832376,1832379,1832535,1833308,1833347,1833833,1834112,1834117,1834287,1834291,1834302,1834326,1834328,1834336,1834428,1834468,1834483,1834610,1834648-1834649,1834681,1834823,1834857-1834858,1835060,1835518,1835521,1835635,1835642,1835780,1835819,1836082,1836121,1836167-1836168,1836170-1836187,1836189-1836196,1836206,1836487,1836493,1837057,1837274,1837296,1837326,1837475,1837503,1837547,1837569,1837600,1837657,1837718,1837998,1838076,1838637,1839549,1839570,1839637,1839746,1840019,1840024,1840031,1840226,1840455,1840462,1840574,1841314,1841352,1842089,1842677,1843222,1843231,1843398,1843618,1843652,1843911,1844325,1844549,1844625,1844627,1844642,1844728,1844775,1844932,1845135,1845336,1845405,1845415,1846057
+/jackrabbit/oak/trunk:1820660-1820661,1820729,1820734,1820859,1820861,1820878,1820888,1820947,1821027,1821130,1821140-1821141,1821178,1821237,1821240,1821249,1821258,1821325,1821358,1821361-1821362,1821370,1821375,1821393,1821477,1821487,1821516,1821617,1821663,1821665,1821668,1821681,1821847,1821975-1821983,1822121,1822201,1822207,1822527,1822642,1822723,1822808,1822850,1822934,1823135,1823163,1823169,1823172,1823655,1823669,1824196,1824198,1824253,1824255,1824896,1824962,1825065,1825362,1825381,1825442,1825448,1825466,1825470-1825471,1825475,1825523,1825525,1825561,1825619-1825621,1825651,1825654,1825992,1826079,1826090,1826096,1826216,1826237,1826338,1826516,1826532,1826551,1826560,1826638,1826640,1826730,1826833,1826932,1826957,1827423,1827472,1827486,1827816,1827977,1828349,1828439,1828502,1828529,1828948,1829527,1829534,1829546,1829569,1829587,1829665,1829854,1829864,1829978,1829985,1829987,1829998,1830019,1830048,1830160,1830171,1830197,1830209,1830239,1830347,1830748,1830911
,1830923,1831157-1831158,1831163,1831190,1831374,1831560,1831689,1832258,1832376,1832379,1832535,1833308,1833347,1833833,1834112,1834117,1834287,1834291,1834302,1834326,1834328,1834336,1834428,1834468,1834483,1834610,1834648-1834649,1834681,1834823,1834857-1834858,1835060,1835518,1835521,1835635,1835642,1835780,1835819,1836082,1836121,1836167-1836168,1836170-1836187,1836189-1836196,1836206,1836487,1836493,1837057,1837274,1837296,1837326,1837475,1837503,1837547,1837569,1837600,1837657,1837718,1837998,1838076,1838637,1839549,1839570,1839637,1839746,1840019,1840024,1840031,1840226,1840455,1840462,1840574,1841314,1841352,1842089,1842677,1843175,1843222,1843231,1843398,1843618,1843652,1843911,1844325,1844549,1844625,1844627,1844642,1844728,1844775,1844932,1845135,1845336,1845405,1845415,1846057
/jackrabbit/trunk:1345480
Modified: jackrabbit/oak/branches/1.8/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.8/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java?rev=1847225&r1=1847224&r2=1847225&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.8/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java (original)
+++ jackrabbit/oak/branches/1.8/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/FilteredSortedSetDocValuesFacetCounts.java Fri Nov 23 09:07:49 2018
@@ -19,9 +19,9 @@
package org.apache.jackrabbit.oak.plugins.index.lucene.util;
import java.io.IOException;
-import java.util.HashMap;
import java.util.Map;
+import com.google.common.collect.Maps;
import org.apache.jackrabbit.oak.plugins.index.lucene.FieldNames;
import org.apache.jackrabbit.oak.spi.query.Filter;
import org.apache.lucene.document.Document;
@@ -34,9 +34,10 @@ import org.apache.lucene.facet.sortedset
import org.apache.lucene.facet.sortedset.SortedSetDocValuesReaderState;
import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.SortedSetDocValues;
+import org.apache.lucene.index.TermsEnum;
import org.apache.lucene.search.ScoreDoc;
import org.apache.lucene.search.TopDocs;
-import org.apache.lucene.util.BytesRef;
+import org.jetbrains.annotations.NotNull;
/**
* ACL filtered version of {@link SortedSetDocValuesFacetCounts}
@@ -65,9 +66,10 @@ class FilteredSortedSetDocValuesFacetCou
}
LabelAndValue[] labelAndValues = topChildren.labelValues;
+ InaccessibleFacetCountManager inaccessibleFacetCountManager = new InaccessibleFacetCountManager();
for (ScoreDoc scoreDoc : docs.scoreDocs) {
- labelAndValues = filterFacet(scoreDoc.doc, dim, labelAndValues);
+ labelAndValues = filterFacet(scoreDoc.doc, dim, labelAndValues, inaccessibleFacetCountManager);
}
int childCount = labelAndValues.length;
@@ -79,45 +81,82 @@ class FilteredSortedSetDocValuesFacetCou
return new FacetResult(dim, path, value, labelAndValues, childCount);
}
- private LabelAndValue[] filterFacet(int docId, String dimension, LabelAndValue[] labelAndValues) throws IOException {
- boolean filterd = false;
- Map<String, Long> newValues = new HashMap<String, Long>();
-
+ private LabelAndValue[] filterFacet(int docId, String dimension, LabelAndValue[] labelAndValues,
+ InaccessibleFacetCountManager inaccessibleFacetCountManager) throws IOException {
Document document = reader.document(docId);
- SortedSetDocValues docValues = state.getDocValues();
- docValues.setDocument(docId);
// filter using doc values (avoiding requiring stored values)
if (!filter.isAccessible(document.getField(FieldNames.PATH).stringValue() + "/" + dimension)) {
- filterd = true;
- for (LabelAndValue lv : labelAndValues) {
- long existingCount = lv.value.longValue();
-
- BytesRef key = new BytesRef(FacetsConfig.pathToString(dimension, new String[]{lv.label}));
- long l = docValues.lookupTerm(key);
- if (l >= 0) {
- if (existingCount > 0) {
- newValues.put(lv.label, existingCount - 1);
- } else {
- if (newValues.containsKey(lv.label)) {
- newValues.remove(lv.label);
- }
- }
+
+ SortedSetDocValues docValues = state.getDocValues();
+ docValues.setDocument(docId);
+ TermsEnum termsEnum = docValues.termsEnum();
+
+ long ord = docValues.nextOrd();
+
+ while (ord != SortedSetDocValues.NO_MORE_ORDS) {
+ termsEnum.seekExact(ord);
+ String facetDVTerm = termsEnum.term().utf8ToString();
+ String [] facetDVDimPaths = FacetsConfig.stringToPath(facetDVTerm);
+
+ for (int i = 1; i < facetDVDimPaths.length; i++) {
+ inaccessibleFacetCountManager.markInaccessbile(facetDVDimPaths[i]);
}
+
+ ord = docValues.nextOrd();
}
}
- LabelAndValue[] filteredLVs;
- if (filterd) {
- filteredLVs = new LabelAndValue[newValues.size()];
- int i = 0;
- for (Map.Entry<String, Long> entry : newValues.entrySet()) {
- filteredLVs[i] = new LabelAndValue(entry.getKey(), entry.getValue());
- i++;
+
+ return inaccessibleFacetCountManager.updateLabelAndValue(labelAndValues);
+ }
+
+ static class InaccessibleFacetCountManager {
+ Map<String, Long> inaccessbileCounts = Maps.newHashMap();
+
+ void markInaccessbile(@NotNull String label) {
+ Long count = inaccessbileCounts.get(label);
+ if (count == null) {
+ count = 1L;
+ } else {
+ count--;
}
- } else {
- filteredLVs = labelAndValues;
+ inaccessbileCounts.put(label, count);
}
- return filteredLVs;
+ LabelAndValue[] updateLabelAndValue(LabelAndValue[] currentLabels) {
+ int numZeros = 0;
+
+ LabelAndValue[] newValues;
+
+ for (int i = 0; i < currentLabels.length; i++) {
+ LabelAndValue lv = currentLabels[i];
+ Long inaccessibleCount = inaccessbileCounts.get(lv.label);
+
+ if (inaccessibleCount != null) {
+ long newValue = lv.value.longValue() - inaccessibleCount;
+
+ if (newValue <= 0) {
+ newValue = 0;
+ numZeros++;
+ }
+
+ currentLabels[i] = new LabelAndValue(lv.label, newValue);
+ }
+ }
+
+ if (numZeros > 0) {
+ newValues = new LabelAndValue[currentLabels.length - numZeros];
+ int i = 0;
+ for (LabelAndValue lv : currentLabels) {
+ if (lv.value.longValue() > 0) {
+ newValues[i++] = lv;
+ }
+ }
+ } else {
+ newValues = currentLabels;
+ }
+
+ return newValues;
+ }
}
}
\ No newline at end of file
Modified: jackrabbit/oak/branches/1.8/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.8/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java?rev=1847225&r1=1847224&r2=1847225&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.8/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java (original)
+++ jackrabbit/oak/branches/1.8/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java Fri Nov 23 09:07:49 2018
@@ -26,8 +26,12 @@ import javax.jcr.query.Query;
import javax.jcr.query.QueryManager;
import javax.jcr.query.QueryResult;
import javax.jcr.query.RowIterator;
+import javax.jcr.security.Privilege;
import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import org.apache.jackrabbit.commons.jackrabbit.authorization.AccessControlUtils;
import org.apache.jackrabbit.core.query.AbstractQueryTest;
import org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexConstants;
import org.apache.jackrabbit.oak.query.facet.FacetResult;
@@ -632,6 +636,110 @@ public class FacetTest extends AbstractQ
assertFalse(rows.hasNext());
}
+ public void testNoFacetsIfNoAccess() throws Exception {
+ deny(testRootNode.addNode("test1")).setProperty("jcr:title", "test1");
+ deny(testRootNode.addNode("test2")).addNode("child").setProperty("jcr:title", "test2");
+ deny(testRootNode.addNode("test3").addNode("child")).setProperty("jcr:title", "test3");
+ superuser.save();
+
+ Session anonUser = getHelper().getReadOnlySession();
+ QueryManager queryManager = anonUser.getWorkspace().getQueryManager();
+ Query q = queryManager.createQuery("//*[@jcr:title]/(rep:facet(jcr:title))", Query.XPATH);
+ QueryResult result = q.execute();
+ FacetResult facetResult = new FacetResult(result);
+
+ assertNotNull("facetResult is null", facetResult);
+ assertTrue(facetResult.getDimensions().isEmpty());
+ }
+
+ public void testOnlyAllowedFacetLabelsShowUp() throws Exception {
+ deny(testRootNode.addNode("test1")).setProperty("jcr:title", "test1");
+ deny(testRootNode.addNode("test2")).addNode("child").setProperty("jcr:title", "test2");
+ testRootNode.addNode("test3").addNode("child").setProperty("jcr:title", "test3");
+ superuser.save();
+
+ Session anonUser = getHelper().getReadOnlySession();
+ QueryManager queryManager = anonUser.getWorkspace().getQueryManager();
+ Query q = queryManager.createQuery("//*[@jcr:title]/(rep:facet(jcr:title))", Query.XPATH);
+ QueryResult result = q.execute();
+ FacetResult facetResult = new FacetResult(result);
+
+ assertNotNull("facetResult is null", facetResult);
+ assertEquals("Unexpected number of dimension", 1, facetResult.getFacets("jcr:title").size());
+ FacetResult.Facet facet = facetResult.getFacets("jcr:title").get(0);
+ assertEquals("Unexpected facet label", "test3", facet.getLabel());
+ assertEquals("Unexpected facet count", 1, facet.getCount());
+ }
+
+ public void testInaccessibleFacetCounts() throws Exception {
+ deny(testRootNode.addNode("test1")).setProperty("jcr:title", "test");
+ deny(testRootNode.addNode("test2")).addNode("child").setProperty("jcr:title", "test");
+ testRootNode.addNode("test3").addNode("child").setProperty("jcr:title", "test");
+ testRootNode.addNode("test4").addNode("child").setProperty("jcr:title", "another-test");
+ superuser.save();
+
+ Session anonUser = getHelper().getReadOnlySession();
+ QueryManager queryManager = anonUser.getWorkspace().getQueryManager();
+ Query q = queryManager.createQuery("//*[@jcr:title]/(rep:facet(jcr:title))", Query.XPATH);
+ QueryResult result = q.execute();
+ FacetResult facetResult = new FacetResult(result);
+
+ assertNotNull("facetResult is null", facetResult);
+ assertEquals("Unexpected number of labels", 2, facetResult.getFacets("jcr:title").size());
+ Map<String, Integer> facets = facetResult.getFacets("jcr:title")
+ .stream().collect(Collectors.toMap(FacetResult.Facet::getLabel, FacetResult.Facet::getCount));
+ assertEquals("Unexpected facet count for jcr:title", 1, (int)facets.get("test"));
+ assertEquals("Unexpected facet count for jcr:title", 1, (int)facets.get("another-test"));
+ }
+
+ public void testAllowedSubNodeFacet() throws Exception {
+ allow(
+ deny(testRootNode.addNode("parent")).addNode("child")
+ ).setProperty("jcr:title", "test");
+ superuser.save();
+
+ Session anonUser = getHelper().getReadOnlySession();
+ QueryManager queryManager = anonUser.getWorkspace().getQueryManager();
+ Query q = queryManager.createQuery("//*[@jcr:title]/(rep:facet(jcr:title))", Query.XPATH);
+ QueryResult result = q.execute();
+ FacetResult facetResult = new FacetResult(result);
+
+ assertNotNull("facetResult is null", facetResult);
+ assertEquals("Unexpected number of labels", 1, facetResult.getFacets("jcr:title").size());
+ FacetResult.Facet facet = facetResult.getFacets("jcr:title").get(0);
+ assertEquals("Unexpected facet label", "test", facet.getLabel());
+ assertEquals("Unexpected facet count", 1, facet.getCount());
+ }
+
+ public void testAcRelativeFacetsAccessControl() throws Exception {
+ deny(testRootNode.addNode("test1")).addNode("jc").setProperty("text", "test_1");
+ deny(testRootNode.addNode("test2").addNode("jc")).setProperty("text", "test_2");
+ testRootNode.addNode("test3").addNode("jc").setProperty("text", "test_3");
+ superuser.save();
+
+ Session anonUser = getHelper().getReadOnlySession();
+ QueryManager queryManager = anonUser.getWorkspace().getQueryManager();
+ Query q = queryManager.createQuery("//*[jcr:contains(jc/@text, 'test')]/(rep:facet(jc/text))", Query.XPATH);
+ QueryResult result = q.execute();
+ FacetResult facetResult = new FacetResult(result);
+
+ assertNotNull("facetResult is null", facetResult);
+ assertEquals("Unexpected number of dimension", 1, facetResult.getFacets("jc/text").size());
+ FacetResult.Facet facet = facetResult.getFacets("jc/text").get(0);
+ assertEquals("Unexpected facet label", "test_3", facet.getLabel());
+ assertEquals("Unexpected facet count", 1, facet.getCount());
+ }
+
+ public Node deny(Node node) throws RepositoryException {
+ AccessControlUtils.deny(node, "anonymous", Privilege.JCR_ALL);
+ return node;
+ }
+
+ public Node allow(Node node) throws RepositoryException {
+ AccessControlUtils.allow(node, "anonymous", Privilege.JCR_READ);
+ return node;
+ }
+
private void markIndexForReindex() throws RepositoryException {
superuser.getNode("/oak:index/luceneGlobal").setProperty(REINDEX_PROPERTY_NAME, true);
}