You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/11/15 01:47:00 UTC

[incubator-superset] 01/05: create boiler modal component

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/SO-1117-modal
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit fc914fd347c77cfb3e97e7f5569cd7514d58db0b
Author: hughhhh <hu...@gmail.com>
AuthorDate: Sat Oct 31 13:33:39 2020 -0700

    create boiler modal component
---
 .../src/SqlLab/components/ResultSet.tsx            |  4 ++++
 .../src/SqlLab/components/SaveDatasetModal.tsx     | 26 ++++++++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx
index f83aebb..d1a2c40 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx
@@ -34,6 +34,8 @@ import { prepareCopyToClipboardTabularData } from '../../utils/common';
 import { CtasEnum } from '../actions/sqlLab';
 import { Query } from '../types';
 
+import { SaveDatasetModal } from 'src/SqlLab/components/SaveDatasetModal'
+
 const SEARCH_HEIGHT = 46;
 
 const LOADING_STYLES: CSSProperties = { position: 'relative', minHeight: 100 };
@@ -174,6 +176,7 @@ export default class ResultSet extends React.PureComponent<
       }
       return (
         <div className="ResultSetControls">
+          <SaveDatasetModal />
           <div className="ResultSetButtons">
             {this.props.visualize &&
               this.props.database &&
@@ -385,6 +388,7 @@ export default class ResultSet extends React.PureComponent<
         </div>
         <div>{progressBar}</div>
         <div>{trackingUrl}</div>
+        <SaveDatasetModal />
       </div>
     );
   }
diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
new file mode 100644
index 0000000..2b27841
--- /dev/null
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { FunctionComponent } from 'react';
+import Modal from 'src/common/components/Modal';
+
+
+export const SaveDatasetModal = ({}) => {
+    return (<div>SaveDatasetModal</div>)
+}