You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/07/28 17:46:00 UTC
[jira] [Commented] (SOLR-9959) SolrInfoMBean-s category and
hierarchy cleanup
[ https://issues.apache.org/jira/browse/SOLR-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166591#comment-17166591 ]
David Smiley commented on SOLR-9959:
------------------------------------
[~ab] I noticed {{SolrCore.getMetricNames()}} has no callers, and furthermore the underlying field {{metricNames}} is not populated either. This is not only the case today, but _appears_ to be the case when it was introduced here. What's going on? Hossman's review (very thourough as usual) also pointed this out: "when/who calls {{getMetricNames}} & why"
> SolrInfoMBean-s category and hierarchy cleanup
> ----------------------------------------------
>
> Key: SOLR-9959
> URL: https://issues.apache.org/jira/browse/SOLR-9959
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 7.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-9959.patch, SOLR-9959.patch, SOLR-9959.patch
>
>
> SOLR-9947 changed categories of some of {{SolrInfoMBean-s}}, and it also added an alternative view in JMX, similar to the one produced by {{SolrJmxReporter}}.
> Some changes were left out from that issue because they would break the back-compatibility in 6.x, but they should be done before 7.0:
> * remove the old JMX view of {{SolrInfoMBean}}-s and improve the new one so that it's more readable and useful.
> * in many cases {{SolrInfoMBean.getName()}} just returns a FQCN, but it could be more informative - eg. for highlighter or query plugins this could be the symbolic name of a plugin that users know and use in configuration.
> * top-level categories need more thought. On one hand it's best to minimize their number, on the other hand they need to meaningfully represent the functionality of components that use them. SOLR-9947 made some cosmetic changes, but more discussion is necessary (eg. QUERY vs. SEARCHHANDLER)
> * we should consider removing some of the methods in {{SolrInfoMBean}} that usually don't return any useful information, eg. {{getDocs}}, {{getSource()}} and {{getVersion()}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org