[GitHub] [kafka] showuon commented on a change in pull request #11416: MINOR: Improve createTopics and incrementalAlterConfigs in KRaft

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r734967664



##########
File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##########
@@ -472,11 +478,7 @@ private ApiError createTopic(CreatableTopic topic,
             if (error.isFailure()) return error;
         } else if (topic.replicationFactor() < -1 || topic.replicationFactor() == 0) {
             return new ApiError(Errors.INVALID_REPLICATION_FACTOR,
-                "Replication factor was set to an invalid non-positive value.");
-        } else if (!topic.assignments().isEmpty()) {
-            return new ApiError(INVALID_REQUEST,
-                "Replication factor was not set to -1 but a manual partition " +
-                    "assignment was specified.");
+                "Number of partitions must be larger than 0.");

Review comment:
       typo: "number of partitions" -> "Replication factor"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org