You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/17 07:45:00 UTC
[jira] [Commented] (CB-13788) Specify the minimum required version
of google play services for plugins
[ https://issues.apache.org/jira/browse/CB-13788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328405#comment-16328405 ]
ASF GitHub Bot commented on CB-13788:
-------------------------------------
wf9a5m75 opened a new pull request #428: CB-13788: (android) Specify the minimum required version of google play services for plugins
URL: https://github.com/apache/cordova-android/pull/428
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Extends the `<framework>` tag to accept particular module.
For example:
`<framework src="com.google.android.gms:play-services-maps:+" versions=">=11.8.0" />`
### What testing has been done on this change?
Only StudioBuilder.js
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Specify the minimum required version of google play services for plugins
> ------------------------------------------------------------------------
>
> Key: CB-13788
> URL: https://issues.apache.org/jira/browse/CB-13788
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Affects Versions: cordova-android-7.0.0
> Reporter: Masashi Katsumata
> Assignee: Joe Bowser
> Priority: Major
> Labels: patch
>
> Many plugins use the Google Play Services SDK, but it is really heavy.
> Some developers want to specify particular versions, but not all of plugin developers.
> Some other developers don't want to update their plugin frequently, but want to specify minimum required version.
> I found this code
> [https://github.com/apache/cordova-android/blob/673a6773b2f78ba76d2144c66ab7a3add78648ae/bin/templates/cordova/lib/builders/StudioBuilder.js#L177-L201]
> This allows us to specify like this
> *<framework src="com.google.android.gms:play-services" versions=">=11.8.0" />*
>
> But the code does not accept particular module.
> *<framework src="com.google.android.gms:play-services-maps" versions=">=11.8.0" />*
>
> In order to specify particular module, we need to change the code.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org