You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/07/28 11:20:27 UTC
[PR] Update to arrow/parquet `52.2.0` [datafusion]
alamb opened a new pull request, #11691:
URL: https://github.com/apache/datafusion/pull/11691
## Which issue does this PR close?
N/A
## Rationale for this change
Now that arrow/parquet 52.2.0 is released https://github.com/apache/arrow-rs/issues/5998 let's use it
The main rationale for upgrading is that this has several additional performance improvements related to StringView that @XiangpengHao and @a10y have been working on. It will unblock merging in the string-view2 branch: https://github.com/apache/datafusion/pull/11667
## What changes are included in this PR?
1. Update to arrow/parquet `52.2.0`
2. change to use non deprecated `flattened_fields` API
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
3. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to arrow/parquet `52.2.0` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11691:
URL: https://github.com/apache/datafusion/pull/11691#issuecomment-2254708431
Thanks for the review @jonahgao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to arrow/parquet `52.2.0` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11691:
URL: https://github.com/apache/datafusion/pull/11691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to arrow/parquet `52.2.0` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #11691:
URL: https://github.com/apache/datafusion/pull/11691#discussion_r1694224790
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -1321,7 +1321,7 @@ mod tests {
.map(|i| i.to_string())
.collect();
let coll: Vec<_> = schema
- .all_fields()
+ .flattened_fields()
Review Comment:
Due to https://github.com/apache/arrow-rs/pull/6001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org