You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by jayapriya90 <gi...@git.apache.org> on 2015/11/16 00:21:03 UTC
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
GitHub user jayapriya90 opened a pull request:
https://github.com/apache/storm/pull/880
STORM-1009:Link on http://storm.apache.org/documentation/Kestrel-and-…
…Storm.html is wrong
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jayapriya90/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit b18c6ecefa13570bef097dabb0fbd2c1069aec21
Author: Jayapriya Surendran <pr...@gmail.com>
Date: 2015-11-15T23:18:54Z
STORM-1009:Link on http://storm.apache.org/documentation/Kestrel-and-Storm.html is wrong
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by jayapriya90 <gi...@git.apache.org>.
Github user jayapriya90 commented on the pull request:
https://github.com/apache/storm/pull/880#issuecomment-157168951
@hustfxj and @revans2 Thanks for the review and update. I created new pull request #882 for asf-site branch.
I've also noticed in asf-site branch that auto-generated html files are not ignored. So when I made this change, there were lots of unrelated changes to html files. In previous master branch, auto generated html files were ignored. Should we do the same for asf-site branch as well? If so, I can create a JIRA for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/880#issuecomment-157281699
Maybe we should close this PR as the new same pull request #882 have been created.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/880#issuecomment-164542182
can we close this dup PR now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/880#issuecomment-156880126
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/880#issuecomment-157077703
@jayapriya90 sadly the documentation was moved to the asf-site branch, but the old docs were not removed from the master branch. Could you update your pull request to be against that branch instead?
I am +1 on the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---