You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/16 03:13:12 UTC

Review Request 68374: Windows: Fixed a bug when `taskID` contains a `:`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68374/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.


Repository: mesos


Description
-------

Windows: Fixed a bug when `taskID` contains a `:`.


Diffs
-----

  src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 


Diff: https://reviews.apache.org/r/68374/diff/1/


Testing
-------

TODO


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68374: Windows: Fixed a bug when `taskID` contains a `:`.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68374/
-----------------------------------------------------------

(Updated Aug. 17, 2018, 6:19 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.


Repository: mesos


Description (updated)
-------

Similar to the previous patch which applies the same logic to
`executorId`.


Diffs (updated)
-----

  src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 
  src/slave/state.cpp e7cf84993c74cf6da7fe22d5112e86e039780287 
  src/tests/paths_tests.cpp 4808402f789ebc783b308c03b8e412ba22bf9f5d 


Diff: https://reviews.apache.org/r/68374/diff/2/

Changes: https://reviews.apache.org/r/68374/diff/1-2/


Testing
-------

TODO


Thanks,

Andrew Schwartzmeyer