You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/04/17 18:12:28 UTC

[kudu-CR] WIP: support keys not at the front of a schema

Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15748


Change subject: WIP: support keys not at the front of a schema
......................................................................

WIP: support keys not at the front of a schema

Change-Id: I4d34776db26e057e53739576c300fcd5ee1ec132
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_configuration.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/write_op.cc
M src/kudu/common/common.proto
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/key_util-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/row_changelist.cc
M src/kudu/common/row_changelist.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/webui_util.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/tserver/tablet_service.cc
33 files changed, 440 insertions(+), 313 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/15748/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d34776db26e057e53739576c300fcd5ee1ec132
Gerrit-Change-Number: 15748
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: support keys not at the front of a schema

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15748 )

Change subject: WIP: support keys not at the front of a schema
......................................................................


Patch Set 2:

I think this needs some more fixup to have better test coverage, and also needs to remove some checks to enable the new feature, but perhaps some portion of this can be committed prior to enabling end-to-end.


-- 
To view, visit http://gerrit.cloudera.org:8080/15748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d34776db26e057e53739576c300fcd5ee1ec132
Gerrit-Change-Number: 15748
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 25 Aug 2020 23:23:54 +0000
Gerrit-HasComments: No

[kudu-CR] WIP: support keys not at the front of a schema

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15748 )

Change subject: WIP: support keys not at the front of a schema
......................................................................

WIP: support keys not at the front of a schema

Change-Id: I4d34776db26e057e53739576c300fcd5ee1ec132
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/client/scan_configuration.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/write_op.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/common.proto
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/key_util-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/row_changelist.cc
M src/kudu/common/row_changelist.h
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/server/webui_util.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/key_value_test_schema.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_throttle-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server_authorization-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
65 files changed, 509 insertions(+), 407 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/15748/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d34776db26e057e53739576c300fcd5ee1ec132
Gerrit-Change-Number: 15748
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>