You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/12/28 21:41:13 UTC

[GitHub] mitchell852 commented on issue #3117: Bad regex for PUT method of /api/1.x/users endpoint

mitchell852 commented on issue #3117: Bad regex for PUT method of /api/1.x/users endpoint
URL: https://github.com/apache/trafficcontrol/issues/3117#issuecomment-450431841
 
 
   First of all, I think the`.json` is just silly because does our API support anything other than json? but that's another story i guess. 
   
   But I'd say when in doubt just follow the examples already in routes.go so i guess:
   
   ```
   		{1.4, http.MethodGet, `users/?(\.json)?$`
   		{1.4, http.MethodGet, `users/{id}$`
   		{1.4, http.MethodPut, `users/{id}$`
   		{1.4, http.MethodPost, `users/?$`
   ```
   Also, why is it 1.4? If these are simply rewrites of the Perl routes, it should be 1.1
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services