You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/01 11:24:52 UTC
[GitHub] [nifi] mr1716 opened a new pull request, #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
mr1716 opened a new pull request, #6175:
URL: https://github.com/apache/nifi/pull/6175
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NiFi 10190](https://issues.apache.org/jira/browse/NIFI-10190)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [NiFi 10190](https://issues.apache.org/jira/browse/NIFI-10190) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [X] JDK 11
- [X] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911916049
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/pom.xml:
##########
@@ -97,7 +97,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-cosmos</artifactId>
- <version>${azure-cosmos.version}</version>
+ <version>4.31.0</version>
Review Comment:
This change should be reverted.
##########
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -31,7 +31,7 @@
<azure.identity.version>1.4.5</azure.identity.version>
<!-- azure-identity depends on msal4j transitively, keep these versions consistent -->
<msal4j.version>1.11.0</msal4j.version>
- <azure-cosmos.version>4.26.0</azure-cosmos.version>
+ <azure-cosmos.version>4.31.0</azure-cosmos.version>
Review Comment:
The latest version appears to be 4.32.0, released on 2022-06-28. Can you upgrade to that version?
```suggestion
<azure-cosmos.version>4.32.0</azure-cosmos.version>
```
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-services-api/pom.xml:
##########
@@ -42,7 +42,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-cosmos</artifactId>
- <version>${azure-cosmos.version}</version>
+ <version>4.31.0</version>
Review Comment:
This change should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on a diff in pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911921943
##########
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -31,7 +31,7 @@
<azure.identity.version>1.4.5</azure.identity.version>
<!-- azure-identity depends on msal4j transitively, keep these versions consistent -->
<msal4j.version>1.11.0</msal4j.version>
- <azure-cosmos.version>4.26.0</azure-cosmos.version>
+ <azure-cosmos.version>4.31.0</azure-cosmos.version>
Review Comment:
If so, we can close this issue and wait for the update. I believe that might be the best option here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911926375
##########
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -31,7 +31,7 @@
<azure.identity.version>1.4.5</azure.identity.version>
<!-- azure-identity depends on msal4j transitively, keep these versions consistent -->
<msal4j.version>1.11.0</msal4j.version>
- <azure-cosmos.version>4.26.0</azure-cosmos.version>
+ <azure-cosmos.version>4.31.0</azure-cosmos.version>
Review Comment:
@mr1716 NiFi uses the Jackson Bill-of-Materials dependency in the root Maven configuration to force the latest version across all modules. Based on that approach, NiFi is not subject to the vulnerability. However, it is still worth upgrading this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on a diff in pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911921267
##########
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -31,7 +31,7 @@
<azure.identity.version>1.4.5</azure.identity.version>
<!-- azure-identity depends on msal4j transitively, keep these versions consistent -->
<msal4j.version>1.11.0</msal4j.version>
- <azure-cosmos.version>4.26.0</azure-cosmos.version>
+ <azure-cosmos.version>4.31.0</azure-cosmos.version>
Review Comment:
@exceptionfactory will do. It looks like 4.32.1 is still vulnerable to [CVE-2020-8908](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-8908) So maybe the best thing to do is hold off on this until they fix that issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 closed pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
mr1716 closed pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
URL: https://github.com/apache/nifi/pull/6175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on a diff in pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to 4.31.0
Posted by GitBox <gi...@apache.org>.
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911933610
##########
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##########
@@ -31,7 +31,7 @@
<azure.identity.version>1.4.5</azure.identity.version>
<!-- azure-identity depends on msal4j transitively, keep these versions consistent -->
<msal4j.version>1.11.0</msal4j.version>
- <azure-cosmos.version>4.26.0</azure-cosmos.version>
+ <azure-cosmos.version>4.31.0</azure-cosmos.version>
Review Comment:
@exceptionfactory Thanks for the information. I'll come back to this in a bit. There are a few other updates that I want to test out first that go from >1 CVE to 0 CVE and see how that works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org