You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/13 18:44:22 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #5997: Don't use parquet file offset for file range pruning
tustvold opened a new pull request, #5997:
URL: https://github.com/apache/arrow-datafusion/pull/5997
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
file_offset is not the offset into the file where the column is located, but rather is the location of non-inlined metadata - https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L781. Some writers such as DuckDB will set it to 0, causing all row groups to be scheduled into the same partition
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5997: Don't use parquet file offset for file range pruning
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5997:
URL: https://github.com/apache/arrow-datafusion/pull/5997#issuecomment-1507488008
I will give this a test on my performance machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #5997: Don't use parquet file offset for file range pruning
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5997:
URL: https://github.com/apache/arrow-datafusion/pull/5997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5997: Don't use parquet file offset for file range pruning
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5997:
URL: https://github.com/apache/arrow-datafusion/pull/5997#discussion_r1165940245
##########
datafusion/core/src/physical_plan/file_format/parquet/row_groups.rs:
##########
@@ -53,7 +53,11 @@ pub(crate) fn prune_row_groups(
let mut filtered = Vec::with_capacity(groups.len());
for (idx, metadata) in groups.iter().enumerate() {
if let Some(range) = &range {
- let offset = metadata.column(0).file_offset();
+ let col = metadata.column(0);
Review Comment:
Given how subtle this is and the lack of test coverage, I think a comment is in order:
```suggestion
// figure out where the first dictionary page (or first data page are)
// note don't use the location of metadata
// <https://github.com/apache/arrow-datafusion/issues/5995>
let col = metadata.column(0);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5997: Don't use parquet file offset for file range pruning
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5997:
URL: https://github.com/apache/arrow-datafusion/pull/5997#issuecomment-1507460483
It would appear that the arrow-rs writer is incorrectly populating this field, I will file an upstream ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org