You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "ReneEnjilian (via GitHub)" <gi...@apache.org> on 2024/10/21 22:16:39 UTC
[PR] [SYSTEMDS-3172] Sparse CSC Block [systemds]
ReneEnjilian opened a new pull request, #2132:
URL: https://github.com/apache/systemds/pull/2132
This PR is just a supplement to a previous task and implements the Sparse CSC Block. MCSC and CSC will most likely only be used for some experiments (@Baunsgaard ) and there will not be a deeper integration for now. Other systems such as PyTorch support both row and column oriented matrix compression formats and now SystemDS does too. I implemented both the row and the column APIs. Further, testing has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3172] Sparse CSC Block [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2132:
URL: https://github.com/apache/systemds/pull/2132#issuecomment-2437596960
LGTM - thanks for the additional sparse block @ReneEnjilian. During the merge I fixed remaining warnings, and removed the wildcard imports. Furthermore, some operations are really slow (the sparse component tests now run 300+ seconds) - accordingly, I will do a few runtime improvements in order to reduce this test runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3172] Sparse CSC Block [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2132:
URL: https://github.com/apache/systemds/pull/2132#issuecomment-2428621953
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `46.58470%` with `391 lines` in your changes missing coverage. Please review.
> Project coverage is 71.02%. Comparing base [(`9b6a96d`)](https://app.codecov.io/gh/apache/systemds/commit/9b6a96dfc0cb0f44d904818edad3ee080b47a11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fac5a5f`)](https://app.codecov.io/gh/apache/systemds/commit/fac5a5f7dcc00190086087fb5b2aa07cacb44792?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2132?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/sysds/runtime/data/SparseBlockCSC.java](https://app.codecov.io/gh/apache/systemds/pull/2132?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fdata%2FSparseBlockCSC.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvZGF0YS9TcGFyc2VCbG9ja0NTQy5qYXZh) | 46.36% | [371 Missing and 20 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2132 +/- ##
============================================
- Coverage 71.14% 71.02% -0.12%
- Complexity 43048 43173 +125
============================================
Files 1446 1447 +1
Lines 164246 164978 +732
Branches 32018 32170 +152
============================================
+ Hits 116847 117179 +332
- Misses 38249 38621 +372
- Partials 9150 9178 +28
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2132?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3172] Sparse CSC Block [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #2132: [SYSTEMDS-3172] Sparse CSC Block
URL: https://github.com/apache/systemds/pull/2132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org