[GitHub] [ozone] duongnguyen0 commented on a diff in pull request #3611: HDDS-7024. Add queue size metric for OM double buffer

[GitBox <gi...@apache.org>]

duongnguyen0 commented on code in PR #3611:
URL: https://github.com/apache/ozone/pull/3611#discussion_r927695654


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/metrics/OzoneManagerDoubleBufferMetrics.java:
##########
@@ -58,6 +59,9 @@ public class OzoneManagerDoubleBufferMetrics {
       "iteration")
   private MutableGaugeFloat avgFlushTransactionsInOneIteration;
 
+  @Metric(about = "DoubleBuffer queue size.", valueName = "Size")
+  private MutableStat queueSize;

Review Comment:
   It's a good point. I think the purpose is to monitor the trend of this buffer usage, and the queue size at flushes (or peak queue size) is enough to track this trend. 
   ```
           flush      
             ↓           ↓   ↓
   1 2 3 4 5 6 0 1 2 3 4 5 0 1 0 
   ```
   
   The intermediate size metric would be helpful if the flushes couldn't happen for any reason or take a long time to complete (in both cases we'll see the intermediate queue size climbing). Yet, it would be a much greater load of datapoints but maybe it's ok because we won't have many OM instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org