You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2018/02/01 05:28:29 UTC
[GitHub] spark pull request #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertR...
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/20467
[SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRegexp` instead of `assertRaisesRegex`.
## What changes were proposed in this pull request?
This is a follow-up pr of #19872 which uses `assertRaisesRegex` but it doesn't exist in Python 2, so some tests fail when running tests in Python 2 environment.
Unfortunately, we missed it because currently Python 2 environment of the pr builder doesn't have proper versions of pandas or pyarrow, so the tests were skipped.
This pr modifies to use `assertRaisesRegexp` instead of `assertRaisesRegex`.
## How was this patch tested?
Tested manually in my local environment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-22274/fup1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20467
----
commit e9a1500be55a9b8a9affcd2513afc262cc2a666b
Author: Takuya UESHIN <ue...@...>
Date: 2018-02-01T05:13:59Z
Use `assertRaisesRegexp` instead of `assertRaisesRegex`.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertR...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20467
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20467
Sorry, actually I am hitting a network problem. Let me try it latter if it's merged.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20467
Thanks, @gatorsmile.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20467
**[Test build #86913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86913/testReport)** for PR 20467 at commit [`e9a1500`](https://github.com/apache/spark/commit/e9a1500be55a9b8a9affcd2513afc262cc2a666b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20467
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20467
**[Test build #86913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86913/testReport)** for PR 20467 at commit [`e9a1500`](https://github.com/apache/spark/commit/e9a1500be55a9b8a9affcd2513afc262cc2a666b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20467
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20467
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20467
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/462/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20467
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86913/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20467: [SPARK-22274][PYTHON][SQL][FOLLOWUP] Use `assertRaisesRe...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20467
Fine. I just merged it
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org