You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/06 11:11:14 UTC

[GitHub] [incubator-uniffle] LuciferYang commented on a diff in pull request #203: [WIP][ISSUE-144] Simplify implementation of `destroyDirectByteBuffer` method and enhance the stability of related test

LuciferYang commented on code in PR #203:
URL: https://github.com/apache/incubator-uniffle/pull/203#discussion_r963578295


##########
common/src/main/java/org/apache/uniffle/common/RssShuffleUtils.java:
##########
@@ -73,15 +72,9 @@ public static ByteBuffer decompressData(ByteBuffer data, int uncompressLength, b
    *
    */
   public static void destroyDirectByteBuffer(ByteBuffer toBeDestroyed)
-          throws IllegalArgumentException, IllegalAccessException,
-          InvocationTargetException, SecurityException, NoSuchMethodException {
+          throws IllegalArgumentException, SecurityException {

Review Comment:
   revert this change due to Java compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org