You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/11/08 15:34:12 UTC
[kudu-CR] [backup] Ensure random tests are reproducible
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11909
Change subject: [backup] Ensure random tests are reproducible
......................................................................
[backup] Ensure random tests are reproducible
Changes the use of Random in the backup tests to
ensure that passing the same seed will result in the
same test being run.
Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 47 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11909/1
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11909 )
Change subject: [backup] Ensure random tests are reproducible
......................................................................
[backup] Ensure random tests are reproducible
Changes the use of Random in the backup tests to
ensure that passing the same seed will result in the
same test being run.
Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Reviewed-on: http://gerrit.cloudera.org:8080/11909
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 47 insertions(+), 41 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11909 )
Change subject: [backup] Ensure random tests are reproducible
......................................................................
Patch Set 2:
It uses a new instance of java.util.Random each time.
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 18:55:54 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11909 )
Change subject: [backup] Ensure random tests are reproducible
......................................................................
Patch Set 2:
The TSAN build cause the create table master crash described in KUDU-2622:
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1541701774.20537#
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 19:04:03 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11909 )
Change subject: [backup] Ensure random tests are reproducible
......................................................................
Patch Set 2: Code-Review+2
So what PRNG instance do Random.nextFoo() calls use?
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 18:44:39 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [backup] Ensure random tests are reproducible
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11909
to look at the new patch set (#2).
Change subject: [backup] Ensure random tests are reproducible
......................................................................
[backup] Ensure random tests are reproducible
Changes the use of Random in the backup tests to
ensure that passing the same seed will result in the
same test being run.
Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 47 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11909/2
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Ensure random tests are reproducible
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11909 )
Change subject: [backup] Ensure random tests are reproducible
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f376ba5709ec118c4327881f7c864b23f92ac4d
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 19:04:09 +0000
Gerrit-HasComments: No