You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2016/06/08 17:52:21 UTC

[jira] [Commented] (FLINK-3958) Access to MetricRegistry doesn't have proper synchronization in some classes

    [ https://issues.apache.org/jira/browse/FLINK-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321053#comment-15321053 ] 

Chesnay Schepler commented on FLINK-3958:
-----------------------------------------

Why? no other method will be called on the reporter until getReporter() is finished.

> Access to MetricRegistry doesn't have proper synchronization in some classes
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-3958
>                 URL: https://issues.apache.org/jira/browse/FLINK-3958
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> In GraphiteReporter#getReporter():
> {code}  com.codahale.metrics.graphite.GraphiteReporter.Builder builder =
>       com.codahale.metrics.graphite.GraphiteReporter.forRegistry(registry);
> {code}
> Access to registry should be protected by lock on ScheduledDropwizardReporter.this
> Similar issue exists in GangliaReporter#getReporter()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)