You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/23 10:27:03 UTC
Review Request 35775: Removed libgen.h include.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/
-----------------------------------------------------------
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos
Description
-------
see summary.
Diffs
-----
src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
src/examples/docker_no_executor_framework.cpp 7993fcd444586fbda8534f9aa8082b3273288895
src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
Diff: https://reviews.apache.org/r/35775/diff/
Testing
-------
make check on trailing RR.
Thanks,
Till Toenshoff
Re: Review Request 35775: Removed libgen.h include.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review89005
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35775/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:27 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/docker_no_executor_framework.cpp 7993fcd444586fbda8534f9aa8082b3273288895
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
>
> Diff: https://reviews.apache.org/r/35775/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 35775: Removed libgen.h include.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review88991
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35775/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 4:27 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/docker_no_executor_framework.cpp 7993fcd444586fbda8534f9aa8082b3273288895
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
>
> Diff: https://reviews.apache.org/r/35775/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 35775: Removed libgen.h include.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review88965
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34256, 35131, 34259, 34260, 34258, 35773, 35774, 35775]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 8:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35775/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:27 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94
> src/examples/docker_no_executor_framework.cpp 7993fcd444586fbda8534f9aa8082b3273288895
> src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326
> src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527
> src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8
> src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55
>
> Diff: https://reviews.apache.org/r/35775/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>