You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/06 16:24:55 UTC

[GitHub] feng-tao commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook

feng-tao commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook
URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r207952035
 
 

 ##########
 File path: airflow/hooks/druid_hook.py
 ##########
 @@ -53,6 +54,8 @@ def __init__(
         self.max_ingestion_time = max_ingestion_time
         self.header = {'content-type': 'application/json'}
 
+        assert self.timeout >= 1
 
 Review comment:
   I would prefer not to put assert outside of test code. Could you change it to throw exception when timeout is less than 1?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services