You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 16:12:32 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1618: Fix predicate pushdown for outer joins

xudong963 commented on a change in pull request #1618:
URL: https://github.com/apache/arrow-datafusion/pull/1618#discussion_r789779763



##########
File path: datafusion/tests/sql/joins.rs
##########
@@ -210,6 +210,26 @@ async fn left_join_unbalanced() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn left_join_filter_pushdown() -> Result<()> {
+    // Since t2 is the non-preserved side of the join, we cannot push down a NULL filter.

Review comment:
       I think after you finish https://github.com/apache/arrow-datafusion/issues/1585, the annotation will be stale. So we can add a todo to update it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org